Skip to content

fix(rehype-shiki): sequential codeboxes are merged together #7805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix(rehype-shiki): sequential codeboxes are merged together #7805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6624ef4
fix(rehype-shiki): sequential codeboxes are merged together
AugustinMauroy Jun 1, 2025
9516d70
fix: typo
AugustinMauroy Jun 1, 2025
bc69c5b
WIP
AugustinMauroy Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/site/pages/en/about/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ server.listen(port, hostname, () => {
});
```

```cjs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that is intentional. Sequential codeboxes are supposed to be merged together afaik.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take a look to the issue. In doc it's supposed to be separated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can make this an opt-in thing, so we can opt-in on api-docs-tooling?

const type = 'commonjs';
```

```mjs
const type = 'module';
```

This is in contrast to today's more common concurrency model, in which OS threads
are employed. Thread-based networking is relatively inefficient and very
difficult to use. Furthermore, users of Node.js are free from worries of
Expand Down
2 changes: 1 addition & 1 deletion packages/rehype-shiki/src/__tests__/highlighter.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ mock.module('shiki/themes/nord.mjs', {
defaultExport: { name: 'nord', colors: { 'editor.background': '#2e3440' } },
});

describe('createHighlighter', async () => {
describe('createHighlighter', { concurrency: true }, async () => {
const { createHighlighter } = await import('../highlighter.mjs');

describe('getLanguageDisplayName', () => {
Expand Down
Loading
Loading