buffer: use Clamp conversion in Blob slice#64739
Open
HoonDongKang wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Align Blob.prototype.slice() with the File API Web IDL definition by using [Clamp] conversion for the start and end arguments. This fixes the Blob-slice.any.js WPT expected failures for fractional start and end values. Refs: https://www.w3.org/TR/FileAPI/#dfn-Blob Signed-off-by: HoonDongKang <d159123@naver.com>
HoonDongKang
force-pushed
the
fix-blob-slice-clamp
branch
from
July 25, 2026 15:07
e284bd7 to
6c536b1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64739 +/- ##
==========================================
- Coverage 90.14% 90.13% -0.01%
==========================================
Files 743 743
Lines 242408 242407 -1
Branches 45656 45644 -12
==========================================
- Hits 218520 218496 -24
- Misses 15387 15401 +14
- Partials 8501 8510 +9
🚀 New features to boost your workflow:
|
panva
approved these changes
Jul 25, 2026
KhafraDev
approved these changes
Jul 25, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns
Blob.prototype.slice()with the File API Web IDL definition:The
startandendarguments should use Web IDL[Clamp]conversion.This fixes the expected failures in
Blob-slice.any.jsfor fractional start/end values.Refs: https://www.w3.org/TR/FileAPI/#dfn-Blob
Testing