Skip to content

url: create URLPattern result properties in WebIDL order#64733

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:url2
Open

url: create URLPattern result properties in WebIDL order#64733
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:url2

Conversation

@Archkon

@Archkon Archkon commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Fixes: #64732

@Archkon
url: create URLPattern result properties in WebIDL order
d822e10 
Reorder the URLPatternResult and URLPatternComponentResult dictionary
templates, together with their value arrays, to follow the
lexicographical member order required by WebIDL.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon

Archkon commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

ping @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jul 25, 2026
@codecov

codecov Bot commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (0618e9f) to head (d822e10).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64733      +/-   ##
==========================================
- Coverage   90.14%   90.13%   -0.01%     
==========================================
  Files         743      743              
  Lines      242408   242408              
  Branches    45656    45652       -4     
==========================================
- Hits       218520   218503      -17     
- Misses      15387    15392       +5     
- Partials     8501     8513      +12
Files with missing lines Coverage Δ
src/node_url_pattern.cc 83.72% <100.00%> (ø)

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

url: URLPattern.exec() result properties are not created in WebIDL order

2 participants

@Archkon @nodejs-github-bot