Skip to content

quic: fix segfault after fragmented client hello#64720

Open
pimterry wants to merge 1 commit into
nodejs:mainfrom
pimterry:fix-quic-handshake-crash
Open

quic: fix segfault after fragmented client hello#64720
pimterry wants to merge 1 commit into
nodejs:mainfrom
pimterry:fix-quic-handshake-crash

Conversation

@pimterry

Copy link
Copy Markdown
Member

If the client hello is fragmented across packets, we start trying to initialize the application before ALPN actually selected an application, so we segfault (repro in the test here).

This changes QUIC session setup to defer processing until an application is selected (i.e. ALPN resolved). Test confirms that session handling after deferring that works fine.

Signed-off-by: Tim Perry <pimterry@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (6572cf5) to head (d491638).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64720      +/-   ##
==========================================
- Coverage   90.13%   90.13%   -0.01%     
==========================================
  Files         741      743       +2     
  Lines      242251   242324      +73     
  Branches    45615    45637      +22     
==========================================
+ Hits       218355   218413      +58     
- Misses      15396    15430      +34     
+ Partials     8500     8481      -19     

see 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants