quic: fix segfault after fragmented client hello#64720
Open
pimterry wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tim Perry <pimterry@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64720 +/- ##
==========================================
- Coverage 90.13% 90.13% -0.01%
==========================================
Files 741 743 +2
Lines 242251 242324 +73
Branches 45615 45637 +22
==========================================
+ Hits 218355 218413 +58
- Misses 15396 15430 +34
+ Partials 8500 8481 -19 🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Jul 24, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the client hello is fragmented across packets, we start trying to initialize the application before ALPN actually selected an application, so we segfault (repro in the test here).
This changes QUIC session setup to defer processing until an application is selected (i.e. ALPN resolved). Test confirms that session handling after deferring that works fine.