module: print required top-level await without side effects#64154
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
anonrig
approved these changes
Jun 26, 2026
aduh95
reviewed
Jun 29, 2026
Previously in order to collect the locations of the TLA, we wait until right before evalutation to ensure instantiation is completed so that we can use v8::Module::GetStalledTopLevelAwaitMessages(). Now we try to add an additioanl shortcut to the source code in the module wraps instead during compilation for modules that contain TLAs and use acron to locate the TLAs when we need to throw ERR_REQUIRE_AYNSC_MODULE, so we can do this as early as before instantiation and do not need to run the module again to collect the locations. In addition, we now collect the require stack for ERR_REQUIRE_ASYNC_MODULE too for better metadata in the errors. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
approved these changes
Jun 29, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
Member
Author
anonrig
approved these changes
Jul 2, 2026
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 85c31df |
joyeecheung
added
dont-land-on-v22.x
Member
Author
|
I noticed that when trying to force push to fix the Windows issue, I was basing off an older version of the branch and therefore reverted some improvements I added later to the branch, e.g. the doc updates, making the properties non-enumerable, etc. Since there's now another commit on the main branch and I think a fixup needs a re-run to confirm Windows is still clean, I opened #64260. Sorry about the mess-up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This paves the way for enabling
--experimental-print-required-tlaby default.Previously in order to collect the locations of the required TLA, we rely on v8::Module::GetStalledTopLevelAwaitMessages() which requires evaluating the module first, hence --experimental-print-required-tla incurred side-effects. This patch switches to parsing the graph using acorn to collect locations of TLAs instead when we need to throw ERR_REQUIRE_AYNSC_MODULE, so that we can print them without evaluating the modules and --experimental-print-required-tla is now free of side-effects.
In addition, we now collect and print the require stack for ERR_REQUIRE_ASYNC_MODULE too. It now carries two more non-enumerable properties:
requireStack: similar to the one carried by ERR_MODULE_NOT_FOUNDtopLevelAwaitLocations: an array containing metadata about the located top-level-awaits in the graph.