Skip to content

crypto: deduplicate X509 subject matching logic#63644

Open
tniessen wants to merge 1 commit into
nodejs:mainfrom
tniessen:x509-dedup-subject-match
Open

crypto: deduplicate X509 subject matching logic#63644
tniessen wants to merge 1 commit into
nodejs:mainfrom
tniessen:x509-dedup-subject-match

Conversation

@tniessen
Copy link
Copy Markdown
Member

CheckHost(), CheckEmail(), and CheckIP() all do very similar things. Extract the common logic into a helper function CheckX509Subject() to avoid duplication.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels May 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.33%. Comparing base (79def6d) to head (0f3664c).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_x509.cc 88.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63644   +/-   ##
=======================================
  Coverage   90.32%   90.33%           
=======================================
  Files         732      732           
  Lines      236435   236428    -7     
  Branches    44527    44520    -7     
=======================================
+ Hits       213563   213577   +14     
  Misses      14589    14589           
+ Partials     8283     8262   -21     
Files with missing lines Coverage Δ
src/crypto/crypto_x509.cc 73.63% <88.00%> (+1.18%) ⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Signed-off-by: Tobias Nießen <tniessen@tnie.de>
@tniessen tniessen force-pushed the x509-dedup-subject-match branch from 2815b81 to 0f3664c Compare May 30, 2026 15:03
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants