Skip to content

lib: cleanup stateless diffiehellman key handling#62645

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:cleanup-dh-followup
Open

lib: cleanup stateless diffiehellman key handling#62645
panva wants to merge 1 commit intonodejs:mainfrom
panva:cleanup-dh-followup

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Apr 9, 2026

semver-major PRs that contain breaking changes and should be released in the next major version. follow up to #62527

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 9, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.81%. Comparing base (e6ef477) to head (dde51f3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #62645   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files         697      697           
  Lines      215773   215736   -37     
  Branches    41279    41271    -8     
=======================================
- Hits       193786   193770   -16     
+ Misses      14093    14086    -7     
+ Partials     7894     7880   -14     
Files with missing lines Coverage Δ
lib/internal/crypto/diffiehellman.js 97.72% <ø> (-0.20%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva requested review from anonrig and jasnell April 10, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants