module: unflag --experimental-strip-types

[marco-ippolito]

It's time to enable it by default to catch some more bugs, currently there are no open issues.
I think it's a semver minor change.

Fixes: nodejs/typescript#17

@nodejs/tsc for visibility

Notable change section:

This change enables the flag --experimental-strip-types by default.
Node.js will be able to execute TypeScript files without additional configuration. Note that there are some limitations in the supported syntax documented at https://nodejs.org/api/typescript.html#type-stripping
This feature is experimental and is subject to change.

[nodejs-github-bot]

Review requested:

• @nodejs/loaders
• @nodejs/performance
• @nodejs/test_runner
• @nodejs/typescript

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (da3f388) to head (d847c32).
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56350      +/-   ##
==========================================
- Coverage   88.54%   88.54%   -0.01%     
==========================================
  Files         657      657              
  Lines      190655   190658       +3     
  Branches    36582    36584       +2     
==========================================
- Hits       168824   168820       -4     
- Misses      15008    15011       +3     
- Partials     6823     6827       +4     

Files with missing lines	Coverage Δ
src/node_options.cc	87.92% <ø> (ø)
src/node_options.h	98.30% <100.00%> (ø)

... and 28 files with indirect coverage changes

[mcollina]

LGTM

[github-actions]

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @marco-ippolito.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64202/

[bmuenzenmeyer]

excited for this, having watched it's development and played with it quite a bit.
some suggestions and questions, none blocking

[anonrig]

What about process.features.typescript? Does that also needs changing?

[marco-ippolito]

What about process.features.typescript? Does that also needs changing?

It works fine, tests are updated (now the default value is 'strip')

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64217/

[ShogunPanda]

Let's go!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64220/

[pmarchini]

except for the doc nit: LGTM, great job @marco-ippolito 🚀

[mcollina]

still lgtm

I would recommend caution and not backport it to v22 for now (maybe after 24 is out?).

[marco-ippolito]

still lgtm

I would recommend caution and not backport it to v22 for now (maybe after 24 is out?).

Yep there is the baking for lts label. I think we can test it for a while on v23 and decide later

Let's give some more time to review

FULL SEND 🚀

[nodejs-github-bot]

Landed in ba59928

[alshdavid]

Does this support ts in node_modules or, more importantly, between packages in an npm workspace?

[ljharb]

@alshdavid i believe neither, by design.

[alshdavid]

@alshdavid i believe neither, by design.

Ah I see. Are there plans to support workspaces?

I'm investigating this for use at Atlassian where we heavily rely on private/unpublished workspace packages. We use typescript exclusively and it would greatly simplify our run scripts and custom tooling

[jakebailey]

Workspaces/monorepos should work fine if your package manager uses symlinks (which they all do?), since the "is node_modules" check is based on the final resolved path.