-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix Node.js 23 column in CHANGELOG.md #55935
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
added
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
v23.x
v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch.
labels
Nov 20, 2024
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Nov 20, 2024
anonrig
approved these changes
Nov 20, 2024
FWIW this affects v23.x but @RafaelGSS I do not think this is worth holding up #55921 for (i.e. this can land separately for the next 23.x release). |
aduh95
approved these changes
Nov 20, 2024
richardlau
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Nov 20, 2024
RafaelGSS
approved these changes
Nov 20, 2024
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 20, 2024
jazelly
approved these changes
Nov 20, 2024
The column for Node.js 23 in `CHANGELOG.md` is missing an opening `<td>` tag so was not correctly rendering.
richardlau
force-pushed
the
changelog
branch
from
November 21, 2024 02:36
b716a27
to
f386574
Compare
LiviaMedeiros
approved these changes
Nov 21, 2024
marco-ippolito
approved these changes
Nov 21, 2024
lpinca
approved these changes
Nov 21, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 22, 2024
Landed in 05b3fcb |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
The column for Node.js 23 in `CHANGELOG.md` is missing an opening `<td>` tag so was not correctly rendering. PR-URL: nodejs#55935 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
The column for Node.js 23 in `CHANGELOG.md` is missing an opening `<td>` tag so was not correctly rendering. PR-URL: #55935 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
meta
Issues and PRs related to the general management of the project.
v23.x
v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The column for Node.js 23 in
CHANGELOG.md
is missing an opening<td>
tag so was not correctly rendering.Before
After