-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v12.6.0 proposal #28508
Release v12.6.0 proposal #28508
Commits on Jul 2, 2019
-
test: make sure test function resolves in test-worker-debug
Use the common `.then(common.mustCall())` check to verify that. Also, we should not use `process.abort()` in `test/parallel`; if the test fails, that leaves core dumps lying around on POSIX systems. PR-URL: #28155 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 993c0db - Browse repository at this point
Copy the full SHA 993c0dbView commit details -
process: hide NodeEnvironmentFlagsSet's
add
functionThis makes sure that the `add` function is not visible by default when inspecting `process.allowedNodeEnvironmentFlags`. PR-URL: #28206 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e517b03 - Browse repository at this point
Copy the full SHA e517b03View commit details -
http2: refactor ping + settings object lifetime management
Have clearer ownership relations between the `Http2Ping`, `Http2Settings` and `Http2Session` objects. Ping and Settings objects are now owned by the `Http2Session` instance, and deleted along with it, so neither type of object refers to the session after it is gone. In the case of `Http2Ping`s, that deletion is slightly delayed, so we explicitly reset its `session_` property. Fixes: #28088 PR-URL: #28150 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d0de204 - Browse repository at this point
Copy the full SHA d0de204View commit details -
Revert "build: remove mips support"
This reverts commit 9334e45. PR-URL: #27992 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2cf37f5 - Browse repository at this point
Copy the full SHA 2cf37f5View commit details -
build: enable openssl support for mips64el
V8 now resume supporting for mipsel/mips64el. This commit add linux64-mips64 platform dependent files in 'deps/openssl/config/archs/linux64-mips64', and update the corresponding gypi files and header files. Refs: https://groups.google.com/forum/#!topic/v8-dev/oXkv5OVCXyc PR-URL: #27992 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cfb5ca3 - Browse repository at this point
Copy the full SHA cfb5ca3View commit details -
doc: remove instructions to post CI links
Remove instructions (in the Collaborator Guide) to post CI links. The bot does that now. PR-URL: #28248 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 17efd93 - Browse repository at this point
Copy the full SHA 17efd93View commit details -
crypto: fix crash when calling digest after piping
When piping data into an SHA3 hash, EVP_DigestFinal_ex is called in hash._flush, bypassing safeguards in the JavaScript layer. Calling hash.digest causes EVP_DigestFinal_ex to be called again, resulting in a segmentation fault in the SHA3 implementation of OpenSSL. A relatively easy solution is to cache the result of calling EVP_DigestFinal_ex until the Hash object is garbage collected. PR-URL: #28251 Fixes: #28245 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 990feaf - Browse repository at this point
Copy the full SHA 990feafView commit details -
test: check custom inspection truncation in assert
The assert module has some truncation logic in a custom inspect function. This was not covered in tests. Add tests to cover it. PR-URL: #28234 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d949ead - Browse repository at this point
Copy the full SHA d949eadView commit details -
Several minor improvements to text. Remove some repetition. PR-URL: #28255 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 168c127 - Browse repository at this point
Copy the full SHA 168c127View commit details -
src: save exec path when initializing Environment
PR-URL: #28252 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 040b9db - Browse repository at this point
Copy the full SHA 040b9dbView commit details -
src: fall back to env->exec_path() for default profile directory
When the current working directory is deleted, fall back to exec_path as the default profile directory. PR-URL: #28252 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c491e4d - Browse repository at this point
Copy the full SHA c491e4dView commit details -
A few dependencies have been updated or added without running license_builder.sh. This updates based on current master branch. PR-URL: #28260 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d95d610 - Browse repository at this point
Copy the full SHA d95d610View commit details -
test: do not spawn rmdir in test-statwatcher
PR-URL: #28276 Refs: #21425 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3a2e67b - Browse repository at this point
Copy the full SHA 3a2e67bView commit details -
lib: refactor unhandled rejection deprecation warning emission
Emit the deprecation warning in the `kDefaultUnhandledRejections` case to reduce the number of branches on unhandled rejection mode - there is now only one switch case on it. Also rename `emitWarning()` to `emitUnhandledRejectionWarning()` to avoid ambiguity with `process.emitWarning()` PR-URL: #28258 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b6a7052 - Browse repository at this point
Copy the full SHA b6a7052View commit details -
src: refactor uncaught exception handling
The C++ land `node::FatalException()` is not in fact fatal anymore. It gives the user a chance to handle the uncaught exception globally by listening to the `uncaughtException` event. This patch renames it to `TriggerUncaughtException` in C++ to avoid the confusion. In addition rename the JS land handler to `onGlobalUncaughtException` to reflect its purpose - we have to keep the alias `process._fatalException` and use that for now since it has been monkey-patchable in the user land. This patch also - Adds more comments to the global uncaught exception handling routine - Puts a few other C++ error handling functions into the `errors` namespace - Moves error-handling-related bindings to the `errors` binding. Refs: 2b252ac PR-URL: #28257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5b92eb4 - Browse repository at this point
Copy the full SHA 5b92eb4View commit details -
test: add Worker + uncaughtException + process.exit() test
PR-URL: #28259 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 72f52a3 - Browse repository at this point
Copy the full SHA 72f52a3View commit details -
doc: clarify when http emits aborted event
PR-URL: #28262 Refs: #28172 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 359e20f - Browse repository at this point
Copy the full SHA 359e20fView commit details -
test: add logging to statwatcher test
Refs: #21425 (comment) PR-URL: #28270 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 424d91a - Browse repository at this point
Copy the full SHA 424d91aView commit details -
tools: update babel-eslint to 10.0.2
PR-URL: #28266 Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd53e6a - Browse repository at this point
Copy the full SHA dd53e6aView commit details -
test: fix flaky test-worker-debug
Address a race condition in the test; the Worker’s exit events may have been not recorded because the Worker exited before the listeners were attached. Fix the by attaching the event listeners before telling the Worker to exit. PR-URL: #28307 Fixes: #28299 Fixes: #28106 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c44db7f - Browse repository at this point
Copy the full SHA c44db7fView commit details -
doc: add gengjiawen to collaborators
PR-URL: #28322 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0856a4d - Browse repository at this point
Copy the full SHA 0856a4dView commit details -
test: use .code for error in setgid
When the 'nobody' user is missing use .code to detect this, its more robust than than the .message string. Refs: #19594 PR-URL: #28219 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c14e4d5 - Browse repository at this point
Copy the full SHA c14e4d5View commit details -
worker: only unref port for stdin if we ref’ed it before
We set the `kStartedReading` flag from `_read()` for Worker stdio, and then `ref()` the port. However, the `.on('end')` handler is also attached when `._read()` is not called, e.g. when `process.stdin` inside a Worker is prematurely ended because stdin was not enabled by the parent thread. In that case, we should not call `.unref()` for stdin if we did not also call `.ref()` for it before. Fixes: #28144 PR-URL: #28153 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2053dd0 - Browse repository at this point
Copy the full SHA 2053dd0View commit details -
test: normalize location test-worker-process-cwd.js runs tests
This change sets the process' directory to __dirname in order to normalize where the test is ran. This addresses the situation that occurs when node is located in the root, and moving up a directory results in the same directory. In that case, an error was thrown because the test interpreted this as a failed directory change. Fixes: #28193 PR-URL: #28271 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 337aef0 - Browse repository at this point
Copy the full SHA 337aef0View commit details -
benchmark: refactor buffer benchmarks
Currently the buffer benchmarks take significantly too long to complete. This drastically reduces the overall runtime by removing obsolete checked variations and reducing the iteration count. It also improves the benchmarks by removing the deprecated `new Buffer(size)` usage and some other small improvements. PR-URL: #26418 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Peter Marshall <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for db65594 - Browse repository at this point
Copy the full SHA db65594View commit details -
This commit adds a version to the diagnostic report feature. PR-URL: #28121 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c4a357d - Browse repository at this point
Copy the full SHA c4a357dView commit details -
doc: revise strict mode text in assert
Revise the text describing `strict` mode. PR-URL: #28285 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1f2b8c8 - Browse repository at this point
Copy the full SHA 1f2b8c8View commit details -
doc: document PerformanceNodeTiming.environment field
PR-URL: #28280 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 57ac661 - Browse repository at this point
Copy the full SHA 57ac661View commit details -
src: add error codes to errors thrown in node_i18n.cc
PR-URL: #28221 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0044fd2 - Browse repository at this point
Copy the full SHA 0044fd2View commit details -
build: link libatomic on mac and linux
Fixes #28231 PR-URL: #28232 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4d12cef - Browse repository at this point
Copy the full SHA 4d12cefView commit details -
n-api: make func argument of napi_create_threadsafe_function optional
PR-URL: #27791 Refs: #27592 Reviewed-By: Gabriel Schulhof <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 53297e6 - Browse repository at this point
Copy the full SHA 53297e6View commit details -
test: permit test-graph.signal to work without test runner
test/async-hooks/test-graph.signal.js passes with the test.py test runner but fails if run directly with the `node` executable. Modify the test so it passes in both cases. PR-URL: #28305 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8346596 - Browse repository at this point
Copy the full SHA 8346596View commit details -
test: remove test-ttywrap.writestream.js
The test is never run in CI and may have never worked. Refs: #28304 PR-URL: #28316 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b448db3 - Browse repository at this point
Copy the full SHA b448db3View commit details -
doc: revise assert legacy mode text
Revise the text for the `assert` module's legacy mode to make it simpler and more scannable. PR-URL: #28315 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 51742b8 - Browse repository at this point
Copy the full SHA 51742b8View commit details -
doc: format ECMA-262 with a hyphen
PR-URL: #28309 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6063ceb - Browse repository at this point
Copy the full SHA 6063cebView commit details -
doc: make multipleResolves docs less opinionated
The 'multipleResolves' event does not necessarily indicate an error. This commit makes the documentation less opinionated, and includes potential caveats. PR-URL: #28314 Refs: #24321 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 632fc1f - Browse repository at this point
Copy the full SHA 632fc1fView commit details -
child_process: attach child in promisification
This commit updates the custom exec() and execFile() promisification to attach the ChildProcess instance to the returned Promise. PR-URL: #28325 Fixes: #28244 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Wyatt Preul <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd5e07f - Browse repository at this point
Copy the full SHA dd5e07fView commit details -
doc: remove obsolete external link
The addons documentation links to an external node-qt repo as a production example. That repo hasn't been updated in over five years. This commit removes the link. PR-URL: #28326 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a213eb7 - Browse repository at this point
Copy the full SHA a213eb7View commit details -
doc: drop 'Note that' in addons docs
This commit removes the usage of 'Note that' in the addons documentation. Note that this phrase was not adding anything meaningful to the docs. PR-URL: #28327 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c9226f5 - Browse repository at this point
Copy the full SHA c9226f5View commit details -
doc: fix typo in process.disconnect() docs
"that" should be "the" in this sentence. This commit also restructures the sentence to avoid the word "process's" PR-URL: #28328 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 64f8530 - Browse repository at this point
Copy the full SHA 64f8530View commit details -
bootstrap: --frozen-intrinsics override problem workaround
PR-URL: #28254 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e607055 - Browse repository at this point
Copy the full SHA e607055View commit details -
doc: remote "note that" from BUILDING.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3d6ae65 - Browse repository at this point
Copy the full SHA 3d6ae65View commit details -
doc: remove "note that" from CPP_STYLE_GUIDE.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 71cf558 - Browse repository at this point
Copy the full SHA 71cf558View commit details -
doc: remove "note that" from releases.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 79f23b5 - Browse repository at this point
Copy the full SHA 79f23b5View commit details -
doc: remove "make that" from onboarding.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3daced7 - Browse repository at this point
Copy the full SHA 3daced7View commit details -
doc: remove "note that" from writing-tests.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1591309 - Browse repository at this point
Copy the full SHA 1591309View commit details -
doc: remove "note that" from writing-and-running-benchmarks.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ffba80b - Browse repository at this point
Copy the full SHA ffba80bView commit details -
doc: remove "note that" from using-symbols.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9461ef8 - Browse repository at this point
Copy the full SHA 9461ef8View commit details -
doc: remove "note that" from maintaining-the-build-files.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a67afc8 - Browse repository at this point
Copy the full SHA a67afc8View commit details -
doc: remove "note that" from maintaining-V8.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9ac3a55 - Browse repository at this point
Copy the full SHA 9ac3a55View commit details -
doc: remove "note that" from pull-requests.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 651ab3f - Browse repository at this point
Copy the full SHA 651ab3fView commit details -
doc: remove "note that" from zlib.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6d94620 - Browse repository at this point
Copy the full SHA 6d94620View commit details -
doc: remove "note that" from util.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c3c86b6 - Browse repository at this point
Copy the full SHA c3c86b6View commit details -
doc: remove "note that" from url.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5e979bf - Browse repository at this point
Copy the full SHA 5e979bfView commit details -
doc: remove "note that" from tty.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 204c9d8 - Browse repository at this point
Copy the full SHA 204c9d8View commit details -
doc: remove "note that" from tls.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7bd2cae - Browse repository at this point
Copy the full SHA 7bd2caeView commit details -
doc: remove "note that" from stream.md
PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eba2e3c - Browse repository at this point
Copy the full SHA eba2e3cView commit details -
doc: remove "note that" from process.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b0a6da7 - Browse repository at this point
Copy the full SHA b0a6da7View commit details -
doc: remove "note that" from net.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f299c44 - Browse repository at this point
Copy the full SHA f299c44View commit details -
doc: remove "note that" from modules.md
PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f4c6f7a - Browse repository at this point
Copy the full SHA f4c6f7aView commit details -
doc: remove "note that" from http2.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f0a857f - Browse repository at this point
Copy the full SHA f0a857fView commit details -
doc: remove "note that" from http.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3174bc1 - Browse repository at this point
Copy the full SHA 3174bc1View commit details -
doc: remove "note that" from fs.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d65c90b - Browse repository at this point
Copy the full SHA d65c90bView commit details -
doc: remove "note that" from events.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 520ef83 - Browse repository at this point
Copy the full SHA 520ef83View commit details -
doc: remove "note that" from errors.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7595486 - Browse repository at this point
Copy the full SHA 7595486View commit details -
doc: remove "note that" from domain.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f3b4449 - Browse repository at this point
Copy the full SHA f3b4449View commit details -
doc: remove "note that" from dns.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 33d9cf5 - Browse repository at this point
Copy the full SHA 33d9cf5View commit details -
doc: remove "note that" from dgram.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c41dbf5 - Browse repository at this point
Copy the full SHA c41dbf5View commit details -
doc: remove "note that" from crypto.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 898b69c - Browse repository at this point
Copy the full SHA 898b69cView commit details -
doc: remove "note that" from console.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for af05ad1 - Browse repository at this point
Copy the full SHA af05ad1View commit details -
doc: remove "note that" from cluster.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cb89b3b - Browse repository at this point
Copy the full SHA cb89b3bView commit details -
doc: remove "note that" from cli.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 658c758 - Browse repository at this point
Copy the full SHA 658c758View commit details -
doc: remove "note that" from buffer.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9ca7c86 - Browse repository at this point
Copy the full SHA 9ca7c86View commit details -
doc: remove "note that" from async_hooks.md
PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d384911 - Browse repository at this point
Copy the full SHA d384911View commit details -
doc: remove "note that" from assert.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d759e0f - Browse repository at this point
Copy the full SHA d759e0fView commit details -
n-api: add error message for date expected
PR-URL: #28303 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ed8cee6 - Browse repository at this point
Copy the full SHA ed8cee6View commit details -
crypto: move _scrypt call out of handleError funct
This commit moves the _scrypt function call out of the handleError function, which now only takes in an error object as its parameter. The motivation for this is to hopefully improve readability as it was not clear to me the first time I stepped through the code where the actual call to _scrypt was. PR-URL: #28318 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for def96ae - Browse repository at this point
Copy the full SHA def96aeView commit details -
crypto: move _randomBytes call out of handleError funct
This commit moves the _randomBytes function call out of the handleError function, which now it takes in an error and a buf object as its parameters. PR-URL: #28318 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 47b230a - Browse repository at this point
Copy the full SHA 47b230aView commit details -
crypto: move _pbkdf2 call out of handleError funct
This commit moves the _pbkdf2 function call out of the handleError function, which now only takes in an error and a digest object as its parameters. PR-URL: #28318 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 558e9cf - Browse repository at this point
Copy the full SHA 558e9cfView commit details -
crypto: move _impl call out of handleError funct
This commit moves the _impl function call out of the handleError function, which now only takes in an object as its parameter. PR-URL: #28318 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f21ddb2 - Browse repository at this point
Copy the full SHA f21ddb2View commit details -
test: use regex for OpenSSL function name
This commit modifies test-crypt-scrypt.js to use a regular expression for the function name in the error message, similar to what is done for the error code. The motivation for this change comes from a case where we (Red Hat) patch OpenSSL and the memory limit checking is done in a different function, meaning that the function name from which this error originates differs from that when linking to the OpenSSL version shipped with Node.js. PR-URL: #28289 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5047006 - Browse repository at this point
Copy the full SHA 5047006View commit details -
doc: add example code for fs.existsSync()
PR-URL: #28354 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 818f084 - Browse repository at this point
Copy the full SHA 818f084View commit details -
doc: add example for Buffer.isEncoding()
PR-URL: #28360 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4762399 - Browse repository at this point
Copy the full SHA 4762399View commit details -
doc: fix sentence about Http2Stream destruction
PR-URL: #28336 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d25d40e - Browse repository at this point
Copy the full SHA d25d40eView commit details -
test: fix assertion argument order in test-buffer-failed-alloc-type
PR-URL: #28349 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 758a003 - Browse repository at this point
Copy the full SHA 758a003View commit details -
doc: add missing word in frameError event docs
PR-URL: #28387 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0e6196c - Browse repository at this point
Copy the full SHA 0e6196cView commit details -
doc,n-api: fix metadata for napi_create_threadsafe_function
PR-URL: #28410 Refs: #27791 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 91d5a4d - Browse repository at this point
Copy the full SHA 91d5a4dView commit details -
test: duplicated buffer in test-stream2-writable.js
PR-URL: #28380 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 16926a8 - Browse repository at this point
Copy the full SHA 16926a8View commit details -
test: move non-pummel crypto DH tests to parallel
Some parts of pummel/test-crypto-dh.js will be just fine in parallel/test-crypto-dh.js. Move them there. PR-URL: #28390 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e161744 - Browse repository at this point
Copy the full SHA e161744View commit details -
test: split pummel crypto dh test into two separate tests
Split test-crypto-dh into two tests so that it does not time out in CI. With a recent OpenSSL upgrade, getDiffieHellman() is much slower than before. PR-URL: #28390 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9f508e3 - Browse repository at this point
Copy the full SHA 9f508e3View commit details -
test: make test-dh-regr more efficient where possible
test-dh-regr is timing out in CI because crypto.createDiffieHellman() is considerably slower after an OpenSSL upgrade. This PR modifies the change from 11ad744 which made the test FIPS-compatible. When not in FIPS mode, the test will use a shorter key which will enable it to run much faster. PR-URL: #28390 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 69f17f1 - Browse repository at this point
Copy the full SHA 69f17f1View commit details -
doc: add example code for worker.isDead() to cluster.md
PR-URL: #28362 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b6d0cbc - Browse repository at this point
Copy the full SHA b6d0cbcView commit details -
doc: cleanup pendingSettingsAck docs
This commit rephrases the first sentence of the http2 session pendingSettingsAck property docs. It also formats SETTINGS consistently. PR-URL: #28388 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3d693c5 - Browse repository at this point
Copy the full SHA 3d693c5View commit details -
doc: fix nits regarding stream utilities
* Unify headings. * Conform method mentions with the style guide. * Fix links. PR-URL: #28385 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e3dd4d5 - Browse repository at this point
Copy the full SHA e3dd4d5View commit details -
test: fix order of assertion arguments in test-event-emitter-num-args
PR-URL: #28368 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4973f21 - Browse repository at this point
Copy the full SHA 4973f21View commit details -
vm: increase code coverage of source_text_module.js
PR-URL: #28363 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e6c7ebe - Browse repository at this point
Copy the full SHA e6c7ebeView commit details -
test: change order of arguments
PR-URL: #28359 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4bca4a5 - Browse repository at this point
Copy the full SHA 4bca4a5View commit details -
test: tls switch arguments order for the assertion
PR-URL: #28340 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ecf4494 - Browse repository at this point
Copy the full SHA ecf4494View commit details -
PR-URL: #28339 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3bc62b9 - Browse repository at this point
Copy the full SHA 3bc62b9View commit details -
doc: remove N-API version for Experimental APIs
Experimental APIs should not have an N-API version specified. Remove cases were one had been added incorrectly. PR-URL: #28330 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e55d0ef - Browse repository at this point
Copy the full SHA e55d0efView commit details -
add a new getter to duplex stream to replace the property `this .writableState.finished` of the object that inherited duplex. Refs: #445 PR-URL: #28007 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1650bcf - Browse repository at this point
Copy the full SHA 1650bcfView commit details -
http2: use writableFinished instead of _writableState
PR-URL: #28007 Refs: #445 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d8942f8 - Browse repository at this point
Copy the full SHA d8942f8View commit details -
tools: fix typo in cache_builder.cc
PR-URL: #28418 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 619eb93 - Browse repository at this point
Copy the full SHA 619eb93View commit details -
doc: replace version with REPLACEME
Node 12.4.0 has already been released. Replace the version with REPLACEME so that the proper version gets inserted at release time. PR-URL: #28431 Refs: #28007 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5367d02 - Browse repository at this point
Copy the full SHA 5367d02View commit details -
test: switch the param order in the assertion
Switch the param order in the assertion at line 140 so that they are in the correct order (actual, expected) PR-URL: #28341 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b822545 - Browse repository at this point
Copy the full SHA b822545View commit details -
test: eliminate duplicate statements
PR-URL: #28342 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e63990e - Browse repository at this point
Copy the full SHA e63990eView commit details -
test: refactoring test, reordering arguments
Refactors the test-buffer-inheritance.js test, switches the order of the arguments to be: 'actual', 'expected' PR-URL: #28343 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d88c697 - Browse repository at this point
Copy the full SHA d88c697View commit details -
test didn't throw the error, it was just returning it. So I removed the try/catch and assigned the error to a variable PR-URL: #28345 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cd78c5e - Browse repository at this point
Copy the full SHA cd78c5eView commit details -
net: replace _writableState.finished with writableFinished
Replace usage of quasi-private _writableState.finished with public writableFinished property. PR-URL: #27974 Refs: #445 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8ad880f - Browse repository at this point
Copy the full SHA 8ad880fView commit details -
tools: update remark-preset-lint-node to 1.7.0
This update enables linting for "note that" in our docs. That phrase is almost always superfluous. Sentences are almost always clearer and stronger without it. PR-URL: #28393 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 03e3ccd - Browse repository at this point
Copy the full SHA 03e3ccdView commit details -
doc: clarify response.finished
PR-URL: #28411 Refs: jshttp/on-finished#30 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3c047b3 - Browse repository at this point
Copy the full SHA 3c047b3View commit details -
This updates eslint from v6.0.0-alpha.2 to v6.0.1 This also removes eslint-disable comments about `bigint` typeof checks. Those would otherwise have caused linting errors now that `bigint` is accepted as valid entry. PR-URL: #28173 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b744bd9 - Browse repository at this point
Copy the full SHA b744bd9View commit details -
process: split routines used to enhance fatal exception stack traces
Previously the enhancement were done right after emitting `'uncaughtException'`, which meant by the time we knew the exception was fatal in C++, the error.stack had already been patched. This patch moves those routines to be called later during the fatal exception handling, and split them into two stages: before and after the inspector is notified by the invocation of `V8Inspector::exceptionThrown`. We now expand the stack to include additional informations about unhandled 'error' events before the inspector is notified, but delay the highlighting of the frames until after the inspector is notified, so that the ANSI escape sequences won't show up in the inspector console. PR-URL: #28308 Fixes: #28287 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0fd6524 - Browse repository at this point
Copy the full SHA 0fd6524View commit details -
doc: clean up isDead() example
This commit removes extra whitespace and some awkward text containing typos from the cluster worker.isDead() code sample. PR-URL: #28421 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 96e8b98 - Browse repository at this point
Copy the full SHA 96e8b98View commit details -
doc: add links to 12.5.0 changelog notable changes
PR-URL: #28450 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0d2d116 - Browse repository at this point
Copy the full SHA 0d2d116View commit details -
doc: update readline asyncIterator docs
This commit: - Removes an unnecessary stability index entry. These generally are not included for Stable entries. - Remove mention of experimental status that is not true anymore. - Remove use of "we" - Remove use of relative time phrasing. - Misc cleanup. PR-URL: #28425 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3fea2e4 - Browse repository at this point
Copy the full SHA 3fea2e4View commit details -
Instead of `for`-`await`-`of`, prefer `for await...of`. PR-URL: #28425 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 14f6cee - Browse repository at this point
Copy the full SHA 14f6ceeView commit details -
test: use assert() in N-API async test
The `Execute()` callback is not allowed to call into JS, so we should use `assert()` instead of potentially throwing JS errors. PR-URL: #28423 Fixes: nodejs/help#1998 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 79b1bf5 - Browse repository at this point
Copy the full SHA 79b1bf5View commit details -
PR-URL: #28417 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 60cf911 - Browse repository at this point
Copy the full SHA 60cf911View commit details -
tools: remove out-of-date code-cache-path comment
This commit removes the comment in cache_builder.cc regarding the usage of --code-cache-path with configure. Commit 14df42f ("build: run `mkcodecache` as an action") deprecated this option and it is always set to yes (unless cross compiling). PR-URL: #28419 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3d014e1 - Browse repository at this point
Copy the full SHA 3d014e1View commit details -
tools: remove unused using declarations
PR-URL: #28422 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 21d2bdd - Browse repository at this point
Copy the full SHA 21d2bddView commit details -
test: do not use fixed port in async-hooks/test-httparser-reuse
Otherwise this was failing on machines which already had a service running on port 3000. PR-URL: #28312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dce4947 - Browse repository at this point
Copy the full SHA dce4947View commit details -
http2: propagate session destroy code to streams
Currently, when an HTTP2 session is destroyed with a code, that code is not propagated to the destroy() call of the session's streams. This commit forwards any code used to destroy a session to its corresponding streams. PR-URL: #28435 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d8d4f9b - Browse repository at this point
Copy the full SHA d8d4f9bView commit details -
test: reset validity dates of expired certs
PR-URL: #28473 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 82b80e0 - Browse repository at this point
Copy the full SHA 82b80e0View commit details -
Notable changes: - Support for the Haiku platform has been added. - The maximum UV_THREADPOOL_SIZE has been increased from 128 to 1024. - uv_fs_copyfile() now works properly when the source and destination files are the same. PR-URL: #28449 Fixes: #27746 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4367732 - Browse repository at this point
Copy the full SHA 4367732View commit details -
tools: change editorconfig's 'ignore' to 'unset'
According to https://editorconfig.org/#supported-properties the canonical way to disable a property is to set it to 'unset'. We did use 'ignore' and this generally works because tools ignore unknown values but some of them like `eclint` are picky on it. PR-URL: #28440 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b808484 - Browse repository at this point
Copy the full SHA b808484View commit details -
esm: ensure cwd-relative imports for module --eval
PR-URL: #28389 Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c9a96ae - Browse repository at this point
Copy the full SHA c9a96aeView commit details -
PR-URL: #28452 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 624fd17 - Browse repository at this point
Copy the full SHA 624fd17View commit details -
process: expose uv_rusage on process.resourcesUsage()
As discussed in nodejs/diagnostics#161, the core should expose important metrics about the runtime, this PR's goal is to let user get the number of io request made, and lower level mertrics like the page faults and context switches. PR-URL: #28018 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 19f9281 - Browse repository at this point
Copy the full SHA 19f9281View commit details -
This corrects a typo in the process.resourceUsage() docs. The field is named swappedOut, not swapedOut. PR-URL: #28497 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0111c61 - Browse repository at this point
Copy the full SHA 0111c61View commit details -
http2: remove square brackets from parsed hostname
Make `http2.connect()` work when using URLs with literal IPv6 addresses. Fixes: #28216 PR-URL: #28406 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fd4d1e2 - Browse repository at this point
Copy the full SHA fd4d1e2View commit details -
test: add tests to assert.ok and improve coverage
Refs: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/assert.js.html#L364 PR-URL: #28355 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 004d26d - Browse repository at this point
Copy the full SHA 004d26dView commit details -
test: add test to doesNotThrow; validate if actual with regex
Refs: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/assert.js.html#L736 PR-URL: #28355 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 937afcc - Browse repository at this point
Copy the full SHA 937afccView commit details -
lib: fix stack overflow check to not break on primitives
PR-URL: #28338 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5f9ee9f - Browse repository at this point
Copy the full SHA 5f9ee9fView commit details -
src: don't abort on EIO when restoring tty
EIO has been observed to be returned by the Linux kernel under some circumstances. Reading through drivers/tty/tty_io*.c, it seems to indicate the tty went away. Of course none of this is documented. Fixes: #28479 PR-URL: #28490 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 035b613 - Browse repository at this point
Copy the full SHA 035b613View commit details -
doc: merge bootstrap/README.md into BUILDING.md
plus some minor tweaks PR-URL: #28465 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eee66c5 - Browse repository at this point
Copy the full SHA eee66c5View commit details -
tools: fix v8 testing with devtoolset on ppcle
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them if not present. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d38b985 - Browse repository at this point
Copy the full SHA d38b985View commit details -
tools: move python code out of jenkins shell
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes python code into tools and runs it. Move these scripts into tools for better maintainability. Once this lands and is back-ported into LTS branches a bunch of shell code can be deleted from the job. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 40ae2a6 - Browse repository at this point
Copy the full SHA 40ae2a6View commit details -
tools: update unified-args to 7.0.0 for md-lint CLI
Update unified-args from 6.0.0 to 7.0.0 for tools/node-lint-md-cli-rollup. This removes a vulnerable package ([email protected]) from the dependencies. Refs: https://app.snyk.io/vuln/SNYK-JS-SETVALUE-450213 PR-URL: #28434 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1b4a7fb - Browse repository at this point
Copy the full SHA 1b4a7fbView commit details -
test: skip tests related to CI failures on AIX
These tests seem to trigger failures in the entire CI job (not just the test) on AIX. Skip them to see if that helps alleviate spurious failures in node-test-commit-aix (and the upstream PR and commit test jobs). See: - nodejs/build#1820 (comment) - nodejs/build#1847 (comment) PR-URL: #28469 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3f6f968 - Browse repository at this point
Copy the full SHA 3f6f968View commit details -
test: fix flaky test-vm-timeout-escape-nexttick
PR-URL: #28461 Fixes: #24120 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8a64b70 - Browse repository at this point
Copy the full SHA 8a64b70View commit details -
build: expose napi_build_version variable
Expose `napi_build_version` to allow `node-gyp` to make it available for building native addons. Fixes: nodejs/node-gyp#1745 Refs: nodejs/abi-stable-node#371 PR-URL: #27835 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cd71aad - Browse repository at this point
Copy the full SHA cd71aadView commit details -
This upgrade is a small patch release, fixing compilation errors on Android, Cygwin, and uClibc - none of which are tested in the CI. PR-URL: #28511 Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3a493b8 - Browse repository at this point
Copy the full SHA 3a493b8View commit details -
2019-07-03, Version 12.6.0 (Current)
Notable changes: * build: * Experimental support for building Node.js on MIPS architecture is back. #27992 * child_process: * The promisified versions of `child_process.exec` and `child_process.execFile` now both return a `Promise` which has the child instance attached to their `child` property. #28325 * deps: * Updated libuv to 1.30.1. #28449, #28511 * Support for the Haiku platform has been added. * The maximum `UV_THREADPOOL_SIZE` has been increased from 128 to 1024. * `uv_fs_copyfile()` now works properly when the source and destination files are the same. * process: * A new method, `process.resourceUsage()` was added. It returns resource usage for the current process, such as CPU time. #28018 * src: * Fixed an issue related to stdio that could lead to a crash of the process in some circumstances. #28490 * stream: * Added a `writableFinished` property to writable streams. It indicates that all the data has been flushed to the underlying system. #28007 * worker: * Fixed an issue that prevented worker threads to listen for data on stdin. #28153 * meta: * Added Jiawen Geng (https://github.com/gengjiawen) to collaborators. #28322 PR-URL: #28508
Configuration menu - View commit details
-
Copy full SHA for e71a0f4 - Browse repository at this point
Copy the full SHA e71a0f4View commit details