feat: update gyp-next to v0.20.0 #3149
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the gyp-next dependency to version v0.20.0 and incorporates minor refactorings and maintenance changes across the codebase and workflows. Key changes include:
- Reordering and consolidating import statements for consistency.
- Standardizing assert statements and minor improvement in error messages.
- Updating GitHub Actions workflows to use updated actions, build commands, and testing matrices.
Reviewed Changes
Copilot reviewed 47 out of 49 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| gyp/pylib/gyp/easy_xml.py | Reordered import statements. |
| gyp/pylib/gyp/common_test.py | Adjusted assert statement style. |
| gyp/pylib/gyp/common.py | Reordered imports and removed redundant code. |
| gyp/pylib/gyp/init.py | Updated import order and introduced walrus operator in ShlexEnv. |
| gyp/pylib/gyp/MSVSVersion.py | Moved the glob import to the top. |
| gyp/pylib/gyp/MSVSUtil.py | Removed an unnecessary blank line. |
| gyp/pylib/gyp/MSVSUserFile.py | Changed import style for easy_xml. |
| gyp/pylib/gyp/MSVSToolFile.py | Changed import style for easy_xml. |
| gyp/pylib/gyp/MSVSSettings_test.py | Changed import style for MSVSSettings. |
| gyp/pylib/gyp/MSVSProject.py | Changed import style for easy_xml. |
| gyp/gyp_main.py | Reordered import statements. |
| gyp/docs/InputFormatReference.md | Added references for library_dirs in the input formats. |
| gyp/docs/Hacking.md | Updated pip installation command. |
| gyp/CHANGELOG.md | Added changelog entries for version v0.20.0. |
| gyp/.github/workflows/release-please.yml | Updated the build command to use pipx. |
| gyp/.github/workflows/python_tests.yml | Updated testing matrices and linting actions. |
| gyp/.github/workflows/nodejs.yml | Adjusted matrix configuration and added a custom Windows runner. |
| gyp/.github/workflows/node-gyp.yml | Adjusted matrix configuration and updated pip installation command. |
Files not reviewed (2)
- gyp/.gitignore: Language not supported
- gyp/.release-please-manifest.json: Language not supported
Comments suppressed due to low confidence (2)
gyp/.github/workflows/release-please.yml:29
- Ensure that pipx is available in the environment or add an installation step for pipx before using it to run the build command.
run: pipx run build
gyp/.github/workflows/node-gyp.yml:20
- Confirm that using 'windows-2025' as the OS runner in the matrix is intentional and that such a runner is available.
os: windows-2025
|
@cclauss @legendecas It doesn't look like it to me, but I wanted to confirm that the breaking changes in |
|
It was marked as a breaking change in gyp-next because of existing gyp in the wild potentially rely on the unintended behavior: nodejs/gyp-next#284 (review) and the unindended behavior was only presented in the I don't think node-gyp public interface is affected. But this can be a notable change. |
This is an automated update of the gyp-next to https://github.com/nodejs/gyp-next/releases/tag/v0.20.0.