fix: start CI when the duplicate check cannot query Jenkins - #1195
Merged
Merged
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
+ Coverage 58.74% 58.78% +0.03%
==========================================
Files 53 53
Lines 10427 10437 +10
==========================================
+ Hits 6125 6135 +10
Misses 4302 4302 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
richardlau
approved these changes
Sep 17, 2026
panva
approved these changes
Sep 17, 2026
aduh95
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ncu-ci run --check-for-duplicatesfetches the most recentCI:build linked on the PR to compare itsCOMMIT_SHA_CHECK. When Jenkins no longer serves that build as JSON (it currently answers with an HTML error page for several node-test-pull-request builds, e.g. 77459),request.json()throws aSyntaxError, the whole run aborts and the Auto Start CI workflow labels the PRrequest-ci-failedon every attempt. See nodejs/node#65986 (comment).Catch the failure of that lookup, warn, skip the duplicate check and start a new CI run instead. A matching
COMMIT_SHA_CHECKstill refuses to start a duplicate.