ci: declare contents:read on the lint job#1077
Open
arpitjain099 wants to merge 2 commits into
Open
Conversation
aduh95
reviewed
May 27, 2026
The lint job only runs eslint after checkout + setup-node. No GitHub API write. The block sits on the job rather than at workflow scope because the `test` job uses pkgjs/action's reusable node-test workflow, and adding a caller-level permissions block would intersect with the callee's grant. Style matches the workflow-level permissions block in commitlint.yml (contents:read) and release-please.yml (id-token:write + contents:read). Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
chore/lint-permissions
branch
from
June 10, 2026 07:23
21e6ded to
3aa779d
Compare
Per review, hoist the permissions block from the lint job to the workflow scope so it applies as the default for all jobs. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Author
|
Moved it to the top level, thanks. |
Renegade334
approved these changes
Jul 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
- Coverage 71.72% 62.01% -9.71%
==========================================
Files 41 46 +5
Lines 5895 7505 +1610
==========================================
+ Hits 4228 4654 +426
- Misses 1667 2851 +1184 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the
lintjob tocontents: read. The job only runsactions/checkout,actions/setup-node,npm install, andnpm run lint. No GitHub API write.Block sits on the job rather than at workflow scope on purpose: the second job (
test) usespkgjs/action's reusablenode-test.yaml@v0, and a caller-level permissions block intersects with the callee's grant (which might needcodecov-action's id-token write or similar). Scoping the new declaration tolintleaves the test job untouched.Defense-in-depth motivation is the CVE-2025-30066 precedent: a compromised third-party action runs inside the existing job context with whatever scope the token was issued at; the explicit cap bounds the blast radius. Matches the workflow-level
contents: readincommitlint.ymland theid-token: write+contents: readinrelease-please.yml. YAML validated locally withyaml.safe_load.BEGIN_COMMIT_OVERRIDE
chore: declare contents:read on the GHA test workflow (#1077)
END_COMMIT_OVERRIDE