Change the check for 1xx status code

"status_code >= 100 && status_code < 200" might be faster than "status_code / 100 == 1"
nodejs · May 4, 2019 · c70bd21 · c70bd21
1 parent 4b6da4f
commit c70bd21
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/http_parser.c b/http_parser.c
@@ -886,10 +886,11 @@ size_t http_parser_execute (http_parser *parser,
       case s_res_status_start:
       {
         /* See RFC 7230 section 3.3.3, step 1 */
-        if (parser->status_code / 100 == 1 || /* 1xx e.g. Continue */
+        if ((parser->status_code >= 100 &&
+             parser->status_code < 200) ||    /* 1xx e.g. Continue */
             parser->status_code == 204 ||     /* No Content */
             parser->status_code == 304) {     /* Not Modified */
-            parser->flags |= F_SKIPBODY;
+          parser->flags |= F_SKIPBODY;
         }
         MARK(status);
         UPDATE_STATE(s_res_status);