-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace all other linters with super-linter
- Loading branch information
Showing
12 changed files
with
254 additions
and
177 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
|
||
{ | ||
"problemMatcher": [ | ||
{ | ||
"owner": "markdownlint", | ||
"pattern": [ | ||
{ | ||
"regexp": "^([^:]*):(\\d+):?(\\d+)?\\s([\\w-\\/]*)\\s(.*)$", | ||
"file": 1, | ||
"line": 2, | ||
"column": 3, | ||
"code": 4, | ||
"message": 5 | ||
} | ||
] | ||
} | ||
] | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
name: Lint | ||
on: | ||
pull_request: | ||
|
||
jobs: | ||
super-linter: | ||
name: Lint | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout Code | ||
uses: actions/checkout@v2 | ||
|
||
- name: Setup Node | ||
uses: actions/setup-node@v1 | ||
|
||
- name: Add matchers | ||
run: | | ||
echo "::add-matcher::.github/super-linter-problem-matcher.json" | ||
- name: Lint Code Base | ||
uses: github/super-linter@v3 | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
FILTER_REGEX_EXCLUDE: .*.template |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,45 @@ | ||
# Contributing to docker-node | ||
|
||
Thank you for your contribution. Here are a set of guidelines for contributing to the docker-node project. | ||
Thank you for your contribution. Here are a set of guidelines for contributing | ||
to the docker-node project. | ||
|
||
## Version Updates | ||
|
||
New **Node.js** releases are released as soon as possible. | ||
|
||
New **NPM** releases are not tracked. We simply use the NPM version bundled in the corresponding Node.js release. | ||
New **NPM** releases are not tracked. We simply use the NPM version bundled in | ||
the corresponding Node.js release. | ||
|
||
**Yarn** is updated to the latest version only when there is a new Node.js SemVer PATCH release (unless Yarn has received a security update), and it's updated only in the branch with the new release, preferably in the same PR. The `update.sh` script does this automatically when invoked with a specific branch, e.g. `./update.sh 6.10`. | ||
**Yarn** is updated to the latest version only when there is a new Node.js | ||
SemVer PATCH release (unless Yarn has received a security update), and it's | ||
updated only in the branch with the new release, preferably in the same PR. The | ||
`update.sh` script does this automatically when invoked with a specific branch, | ||
e.g. `./update.sh 6.10`. | ||
|
||
### Submitting a PR for a version update | ||
|
||
If you'd like to help us by submitting a PR for a version update, please do the following: | ||
|
||
1. [Fork this project.](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) | ||
1. [Clone the forked repository.](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/cloning-a-repository) | ||
1. Create a branch for the update PR. For example, `git checkout master; git checkout -b version-update`. | ||
1. Run `./update.sh`. You can see additional options by using accessing the built-in help documentation with `./update.sh -h`. This script will automatically update the appropriate files with the latest versions and checksums. | ||
1. Commit the modified files to the `version-update` branch and push the branch to your fork. | ||
1. [Create a PR to merge the branch from your fork into this project's master branch.](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork). | ||
If you'd like to help us by submitting a PR for a version update, please do the | ||
following: | ||
|
||
1. [Fork this | ||
project.](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) | ||
1. [Clone the forked | ||
repository.](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/cloning-a-repository) | ||
1. Create a branch for the update PR. For example, `git checkout master; git | ||
checkout -b version-update`. | ||
1. Run `./update.sh`. You can see additional options by using accessing the | ||
built-in help documentation with `./update.sh -h`. This script will | ||
automatically update the appropriate files with the latest versions and | ||
checksums. | ||
1. Commit the modified files to the `version-update` branch and push the branch | ||
to your fork. | ||
1. [Create a PR to merge the branch from your fork into this project's master | ||
branch.](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork). | ||
|
||
## Adding dependencies to the base images | ||
|
||
NodeJS is a big ecosystem with a variety of different use cases. The docker images for node are designed to provide the minimum for running core node. Additional dependencies (including dependencies for npm or yarn such as git) will not be included in these base images and will need to be included in descendent image. | ||
NodeJS is a big ecosystem with a variety of different use cases. The docker | ||
images for node are designed to provide the minimum for running core node. | ||
Additional dependencies (including dependencies for npm or yarn such as git) | ||
will not be included in these base images and will need to be included in | ||
descendent image. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.