Skip to content

hotfix(lightningcss): improve customization#830

Merged
avivkeller merged 2 commits into
mainfrom
hotfix-lightningcss
Jun 4, 2026
Merged

hotfix(lightningcss): improve customization#830
avivkeller merged 2 commits into
mainfrom
hotfix-lightningcss

Conversation

@avivkeller
Copy link
Copy Markdown
Member

@avivkeller avivkeller commented Jun 4, 2026

cc @nodejs/web-infra can we fast-track this little fix?

Nothing is broken, but this is a fix for future consumers

@avivkeller avivkeller requested a review from a team as a code owner June 4, 2026 19:03
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Jun 4, 2026 7:05pm

Request Review

@avivkeller avivkeller added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Jun 4, 2026
@cursor
Copy link
Copy Markdown

cursor Bot commented Jun 4, 2026

PR Summary

Low Risk
Small build-plugin change with no auth or data impact; default behavior is unchanged when no custom resolver is configured.

Overview
Bumps @node-core/doc-kit to 1.3.8 (package and lockfile).

The web CSS Rolldown plugin now merges lightningcss.resolver from doc-kit web config into the bundleAsync resolver instead of replacing it with only Rolldown’s resolve hook. Custom Lightning CSS resolver options (e.g. for future consumers) are kept while Rolldown resolution still runs.

Reviewed by Cursor Bugbot for commit 73b08b3. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.33%. Comparing base (f544c3f) to head (73b08b3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #830   +/-   ##
=======================================
  Coverage   84.33%   84.33%           
=======================================
  Files         172      172           
  Lines       15420    15421    +1     
  Branches     1362     1362           
=======================================
+ Hits        13005    13006    +1     
  Misses       2406     2406           
  Partials        9        9           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

web Generator

File Base Head Diff
all.js 20.17 MB 20.17 MB -238.00 B (-0.00%)
all.html 19.74 MB 19.74 MB -168.00 B (-0.00%)

@avivkeller avivkeller merged commit 9f970f4 into main Jun 4, 2026
25 checks passed
@avivkeller avivkeller deleted the hotfix-lightningcss branch June 4, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants