Skip to content

fix: target node 22.22.2 in esbuild#845

Merged
aduh95 merged 3 commits into
nodejs:mainfrom
MikeMcC399:esbuild-target-node22.22.2
May 15, 2026
Merged

fix: target node 22.22.2 in esbuild#845
aduh95 merged 3 commits into
nodejs:mainfrom
MikeMcC399:esbuild-target-node22.22.2

Conversation

@MikeMcC399
Copy link
Copy Markdown
Contributor

Situation

The npm script build:bundle selects esbuild --target=node18.17.0

See

This may unnecessarily transform JavaScript syntax to the earlier EOL Node.js 18 version, although the repo is now set to minimum Node.js 22.22.2

corepack/package.json

Lines 12 to 14 in 05bc5f3

"engines": {
"node": "^22.22.2 || ^24.15.0 || >=26.0.0"
},

Change

Update build:bundle to --target=node22.22.2

@MikeMcC399
Copy link
Copy Markdown
Contributor Author

Testing chores CI failure is a known issue #837

This test is successful locally running Node.js 24.14.1

@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 15, 2026 12:01
@MikeMcC399
Copy link
Copy Markdown
Contributor Author

requires PR #847 to succeed in CI reliably

@aduh95 aduh95 enabled auto-merge (squash) May 15, 2026 13:46
@aduh95 aduh95 merged commit 0f01502 into nodejs:main May 15, 2026
9 checks passed
@MikeMcC399 MikeMcC399 deleted the esbuild-target-node22.22.2 branch May 15, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants