Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fetching by texture IDs #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TibiNonEst
Copy link
Contributor

@TibiNonEst TibiNonEst commented Feb 14, 2022

Closes #25. This allows you to fetch any resource by its texture ID.

There are two main things to consider with this pr:

  1. Using solely texture IDs, there is no way of knowing whether the skin is of the "slim" model variety or not. This is for the most part a non-issue, however, it causes problems with body rendering. It also means that any request by texture ID will return anX-Crafthead-Skin-Model header of default.
  2. There is also no way of knowing whether the texture is for a skin or cape. Currently, the pr just yolo's it, and requesting a cape just renders the texture as a cape even if it is a skin, and vice versa. This can cause very cursed images, but I guess if someone's requesting texture IDs directly they've probably done the due diligence of knowing what they need.

@TibiNonEst TibiNonEst changed the title Allow fetching by texture ID's Allow fetching by texture IDs Feb 14, 2022
@TibiNonEst
Copy link
Contributor Author

Given people have to know what texture ID to fetch anyway, it's not unreasonable to expect them to know whether or not a skin needs to have a slim model. If we can assume that, it might be helpful to provide a way to request a slim model, perhaps with a query parameter such as ?slim or ?model=slim.

@FN-FAL113
Copy link

This would be handy and opens up support for custom skins that are cached in the texture.minecraft.net/

@Hazmi35
Copy link

Hazmi35 commented Dec 25, 2023

Hello. What are the status on this PR?

@Cherry
Copy link
Member

Cherry commented Mar 3, 2024

Apologies for the delay in getting back to this. We've done a lot of maintenance on this repo since this PR was opened. Is this something folks are still wanting/needing?

@FN-FAL113
Copy link

Apologies for the delay in getting back to this. We've done a lot of maintenance on this repo since this PR was opened. Is this something folks are still wanting/needing?

yes please, It would be a great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for texture IDs
4 participants