-
Notifications
You must be signed in to change notification settings - Fork 181
DRAFT: v7.x #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.x
Are you sure you want to change the base?
DRAFT: v7.x #493
Conversation
…event signature wrapping attacks (node-saml#495)
Given the number of people using xml-crypto and the lack of an alternative (that I'm aware of). It seems prudent to continue developing this. Otherwise, we should provide a migration guide to some other method of doing what this library does. |
# Conflicts: # README.md # src/signed-xml.ts
I definitely don't want to encourage users to use xml signatures if they are building some new feature/product/spec. For SAML implementations, we can still support xml-crypto. |
This significantly improves the security logic around xml-crypto.
Currently, it is an outline, i.e. the code doesn't actually work
Reviewers:
Currently we remove the checkSignature method from the SignedXML class to simplify the logic, and put it in XMLVerifier
Release process debate:
If feel like the best we can do is to deprecate the library entirely,
because xml signatures as a whole is unsafe, and using it will ensure the other side will be insecure. (since other implementations are insecure)