Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing model which are not valid and duplicates #379

Closed
wants to merge 2 commits into from

Conversation

pdhirajkumarprasad
Copy link
Contributor

@pdhirajkumarprasad pdhirajkumarprasad commented Oct 28, 2024

removing models from list which are not valid based on nod-ai/SHARK-ModelDev#812 and remove duplicates using tool introduced here: #376

@saienduri saienduri changed the title removing model which are not valid removing model which are not valid and duplicates Oct 28, 2024
@saienduri
Copy link
Contributor

LGTM, let's wait for @zjgarvey before landing

Copy link
Contributor

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to retain the original shard lists somewhere. I'm not sure if Kumar or others want to still have numbers reported based on the full list with redundant tests.

Do we also need to redistribute across shards?

@pdhirajkumarprasad
Copy link
Contributor Author

I'd like to retain the original shard lists somewhere. I'm not sure if Kumar or others want to still have numbers reported based on the full list with redundant tests.

--I can keep the original list with extension _old but our run should be with the unique model list and it's fine if that lead to lesser no. of model but that will be unique list

Do we also need to redistribute across shards?

--Yes, I can do that

@pdhirajkumarprasad
Copy link
Contributor Author

closing this pull request as the way DUP model was found is not correct and it will reduce the coverage of ops. Once we have correct list, will create the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants