Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR]: YouTube Embedding #19

Merged
merged 3 commits into from
Jun 12, 2024
Merged

[PR]: YouTube Embedding #19

merged 3 commits into from
Jun 12, 2024

Conversation

jimbrig
Copy link
Member

@jimbrig jimbrig commented Jun 3, 2024

Issue #18

@jimbrig jimbrig added config Configuration Management enhancement New feature or request feature New feature requests labels Jun 3, 2024
@jimbrig jimbrig requested a review from phoward38 June 3, 2024 23:03
@jimbrig jimbrig self-assigned this Jun 3, 2024
@height Height
Copy link

height bot commented Jun 3, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@vercel Vercel
Copy link

vercel bot commented Jun 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bastienlaw-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 11:03pm
bastienlaw-remix-eqnq ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 11:03pm

@jimbrig
Copy link
Member Author

jimbrig commented Jun 3, 2024

image

phoward38
phoward38 reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@phoward38 phoward38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimbrig lgtm

phoward38
phoward38 reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@phoward38 phoward38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimbrig lgtm

@jimbrig
Copy link
Member Author

jimbrig commented Jun 12, 2024

@jimbrig lgtm

what's lgtm? lol

@jimbrig jimbrig merged commit f038e8c into main Jun 12, 2024
4 checks passed
@phoward38
Copy link
Member

@jimbrig lgtm

what's lgtm? lol

@jimbrig "Looks good to me" 😂 too many acronyms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoward38 phoward38 phoward38 approved these changes

Assignees

@jimbrig jimbrig

Labels
config Configuration Management enhancement New feature or request feature New feature requests
Projects
None yet
Milestone
[Milestone]: Initial Staging Deployme...
Development

Successfully merging this pull request may close these issues.
2 participants
@jimbrig @phoward38