Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the InvMEGAN_ species needed by combine-ant-bio to the Diagn.rc #70

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Feb 5, 2025

Before HEMCO 3.9.2, these (and others) were automatically included.

The combine-ant-bio script expects them:

if spc == "AACD":
ds_new[spc][:] = ds["InvMEGAN_AAXX"][:]
elif spc == "FACD":
ds_new[spc][:] = ds["InvMEGAN_FAXX"][:]
elif spc == "APIN":
ds_new[spc][:] = ds["InvMEGAN_APIN"][:]

Resolves #69

@zmoon
Copy link
Member Author

zmoon commented Feb 5, 2025

@drnimbusrain @bbakernoaa if this works, we should add it to the other HEMCO_sa_Diagn.rcs too?

@drnimbusrain
Copy link
Member

@zmoon Yes, I agree if this works we should add to the other configs too as they could still be used in theory

@drnimbusrain
Copy link
Member

drnimbusrain commented Feb 5, 2025

I can help test this change, but in fact, the emissions workflow updates points to the cmaq_gfs_megan_nei2019_globtempo config that Jianping is testing. We should make those config changes too.

@zmoon
Copy link
Member Author

zmoon commented Feb 5, 2025

Thanks @drnimbusrain I've copied the new lines to the other files.

@drnimbusrain
Copy link
Member

testing now

@drnimbusrain drnimbusrain self-requested a review February 5, 2025 21:45
@zmoon zmoon marked this pull request as ready for review February 5, 2025 21:53
@drnimbusrain
Copy link
Member

Unfortunately, that change does not add the needed species for post combine and we get the same error.

@zmoon
Copy link
Member Author

zmoon commented Feb 5, 2025

Unfortunately, that change does not add the needed species for post combine and we get the same error.

My other thought was adding /AAXX/FAXX/APIN to the end of the list here:

108 MEGAN : on ISOP/ACET/PRPE/C2H4/ALD2/EOH/MOH/MTPA/MTPO/LIMO/SESQ

@drnimbusrain
Copy link
Member

@zmoon Maybe we need to add them to HEMCO_sa_Spec.rc as well?

@drnimbusrain
Copy link
Member

Ah yes, I think there too

@zmoon zmoon marked this pull request as draft February 7, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nexus_post_split job failed with NEI2019 and AQM_NA_9km grids
2 participants