working towards py3 compatibility #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
manu-chroma
commented
Apr 2, 2017
manu-chroma
commented
- fixed imports
- print statements
|
@nmoya don't approve this yet. This is still WIP. |
nmoya
reviewed
Apr 4, 2017
| @@ -170,24 +173,24 @@ def compute_message_proportions(self, list_of_messages, senders, root, contact): | |||
| self.proportions["avg_words"] = {} | |||
| for s in senders: | |||
| self.proportions["avg_words"][s] = self.proportions["words"][s] / self.proportions["messages"][s] | |||
| self.proportions["avg_words"]["ratio"] = self.proportions["avg_words"][root] / self.proportions["avg_words"][contact] | |||
| self.proportions["avg_words"]["ratio"] = self.proportions["avg_words"][root] / self.proportions["avg_words"][ | |||
| contact] | |||
There was a problem hiding this comment.
haha yeah. pycharm magic 😄
|
@manu-chroma so far so good with the changes, let me know when you update. |
manu-chroma
force-pushed
the
master
branch
4 times, most recently
from
8d0ab0e
to
71caeb8
Compare
- fixed imports - print statements
|
@nmoya Pls review. Python 3.x tests are still not passing, but I've made a bunch of improvements to the codebase. Also, rewritten the test file. |
manu-chroma
commented
Apr 7, 2017
| args = "-f test/testChat2.txt --root Username{}".format(case).split() | ||
|
|
||
| with captured_output() as (result, err): | ||
| parser(args) |
There was a problem hiding this comment.
rather than using os.system, better approach is to import the main package and pass args directly to it.
|
@manu-chroma Sorry for the delay, nice work. Can you remove the *.bak files from the PR? Other than that, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.