oneTBB compatibility #211
Open
oneTBB compatibility #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takeru
reviewed
Aug 3, 2023
| @@ -60,10 +60,12 @@ int main(int argc, char **argv) { | |||
| } | |||
|
|
|||
| // Set the number of threads to use. | |||
| tbb::task_scheduler_init schedule(conf.num_threads > 0 ? conf.num_threads : tbb::task_scheduler_init::automatic); | |||
| if (conf.num_threads > 0) { | |||
| if (num_threads > 0) { | |||
There was a problem hiding this comment.
mvs-texturing/apps/texrecon/texrecon.cpp:63:9: error: ‘num_threads’ was not declared in this scope
63 | if (num_threads > 0) {
should be:
if (conf.num_threads > 0) {
|
@FlorentLM , thank you so much. I spent the entire day trying to resolve a compiler issue related to TBB. Your PR was a great help! |
donlk
added a commit
to donlk/mvs-texturing
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to accomodate for libtbb's replacement, oneTBB (including a bump to mapmap's latest commit which builds fine with oneTBB)