Logging enhancements and apache24 updates #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosherof
commented
Dec 2, 2021
sosherof
commented
- Added additional logging statements.
- Removed all #ifdef _DEBUG around existing logging statements, allow LogLevel to decide.
- Code now inserts an input header "X-SENDFILE-INVOKED" before making a subrequest. The sub-request can cause mod_rewrite to fire a second time. The header allows a RewriteCond to be used to skip any rules that should not re-apply.
- Replaced code that inserts the requested file into buckets with the newer apr_bridge_insert_file command, which properly handles large files.
- Replace code that empties the incoming brigade with apr_brigade_cleanup, which does the same thing but in one command.
- Added APLOG_USE_MODULE statement to allow module level logging.
- Added additional logging. - Removed all #ifdef _DEBUG around existing logging statements, allow LogLevel to decide. - Code now inserts an input header "X-SENDFILE-INVOKED" before making a subrequest, which can cause mod_rewrite to fire a second time. The header allows a RewriteCond to be used to skip any rules that should not re-apply. - Replaced code that insert the requested file into buckets with the newer apr_bridge_insert_file command, which properly handles large files. - Replace code that empties the incoming brigade with apr_brigade_cleanup, which does the same thing but in one command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.