Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] EvaluationPanel run map evaluations in async worker #31

Closed
wants to merge 0 commits into from

Conversation

anan474
Copy link
Contributor

@anan474 anan474 commented May 24, 2024

This PR close #16

Run map evaluation with worker and async making this operation non-blocking.

Unfortunately web worker is not yet supported in HMR (vitejs/vite#5396). So this non-blocking map evaluation only available in production, and will use previous blocking function in development mode.

@cpojer
Copy link
Contributor

cpojer commented May 25, 2024

Thanks for submitting a PR! Please check out the comments and fix the lint issues to make sure CI passes.

@anan474
Copy link
Contributor Author

anan474 commented May 25, 2024

Thanks for submitting a PR! Please check out the comments and fix the lint issues to make sure CI passes.

Thanks for the opportunity! I have updated the code and resolve the issue.

@cpojer
Copy link
Contributor

cpojer commented May 26, 2024

@anan474 Oh no, I'm so sorry. I made a bunch of changes and tried to add them to the commit, but something went wrong :( Would you mind pushing your branch again either to this PR or by creating a new one?

The commits can be found on this branch: https://github.com/nkzw-tech/athena-crisis/tree/anan474/main

@anan474
Copy link
Contributor Author

anan474 commented May 26, 2024

Hi @cpojer, no problem! I don't know how to push to this PR again, so I will create a new one!

Anyway, your fixes and polish is awesome, glad you found the solution for the $RefreshReg$ things, it bothering me for hours to no ends!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Performance] EvaluationPanel should run map evaluations async and/or in a worker
2 participants