fix: flaky fs test

Reported by aws#4390, this test is failing on the mkdirSpy call count assertion.

Not exactly sure why this is flaky, but maybe it is due
to the previous folders not being cleaned up.

This commit deletes the created folders after each test finishes.
Additionally, this commit checks the actual spy call count so that
we can better debug the issue

Signed-off-by: nkomonen <[email protected]>

src/test/srcShared/fs.test.ts

@@ -156,10 +156,15 @@ describe('FileSystem', function () {
 
     describe('mkdir()', function () {
         const paths = ['a', 'a/b', 'a/b/c', 'a/b/c/d/']
+        let dirPath: string // store path for easy cleanup
+
+        afterEach(async function () {
+            await fsCommon.delete(dirPath)
+        })
 
         paths.forEach(async function (p) {
             it(`creates folder: '${p}'`, async function () {
-                const dirPath = createTestPath(p)
+                dirPath = createTestPath(p)
                 await fsCommon.mkdir(dirPath)
                 assert.ok(existsSync(dirPath))
             })
@@ -169,12 +174,12 @@ describe('FileSystem', function () {
             it(`creates folder but uses the "fs" module if in C9: '${p}'`, async function () {
                 sandbox.stub(extensionUtilities, 'isCloud9').returns(true)
                 const mkdirSpy = sandbox.spy(fsPromises, 'mkdir')
-                const dirPath = createTestPath(p)
+                dirPath = createTestPath(p)
 
                 await fsCommon.mkdir(dirPath)
 
                 assert.ok(existsSync(dirPath))
-                assert.ok(mkdirSpy.calledOnce)
+                assert.strictEqual(mkdirSpy.callCount, 1)
             })
         })
     })