OS Windows support (for the release branch) #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify fzf executable path, update version
|
@nk412 I reopened my pull request for the release branch. What do you think about it? |
nk412
reviewed
Jan 7, 2022
pyfzf/pyfzf.py
Outdated
|
|
||
| # Invoke fzf externally and write to output file | ||
| self.sh['-c', f"cat {input_file.name} | fzf {fzf_options} > {output_file.name}"] & FG | ||
| if os.name == "nt": |
There was a problem hiding this comment.
This can be simplified. All platforms can be supported using the subprocess interface, so we don't need a branch just for Windows.
nk412
reviewed
Jan 7, 2022
|
I made improvements to the prompt method, now it looks simpler and works the same on Windows and Linux (I ran short tests). Also fixed a bug with incorrect behavior in the absence of fzf Now only the standard os module is used, subprocess is not used at all. Also, the logic of working with temporary files has been changed to support the Windows platform |
nk412
approved these changes
Jan 12, 2022
Merged
|
@brookite 0.3.0 merged. Also updated the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of my pull request for the release branch. This commit fixes issue #8
What has been done:
-Removed plumbum dependency (now pyfzf uses only standard library modules)
-Added OS Windows support
-Ability to specify fzf executable path