Powerdevil revamp #384
Open
Powerdevil revamp #384
+524
−226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is easier to see the differences when the options are all in on line.
…rnalMonitorIsConnected It is worth noting that the semantics of this option have been inverted by the renaming.
Reformat the code so that it is "more vertical".
To disallow the screen to dim automatically we must set dimAutomatically.idleTimeout to "never".
Extract the general configuration options and move it close to the function that builds the profiles options.
This assertion does not depend on the power profile, so it does not belong to the function.
…dOptionsModulesForProfile
|
I think this mostly looks good, besides the reformatting of lists, because they are formatted like this because of |
|
Looking forward to this - the new display dimming options in kde are annoying. 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to cover all the options present in the configuration screen. I also made some changes to the code structure with the intention of making it more uniform and organized.
As for the option names, my idea was to mirror the texts of the options on the configuration screen. I think that even with longer names, it will be easier for the end user to assemble their configuration from the screens.
Please consider my contribution as a suggestion and not as an attempt to change for the sake of change. We can and should discuss these changes and, if necessary, reach a compromise in terms of nomenclature and organization.
One more thing: don't be scared by the number of commits, it's just my way of working. I suggest that you analyze the changes based on the final code.