Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: initial flake-parts modules #2858

Merged
merged 3 commits into from
Jan 19, 2025

Conversation

MattSturgeon
Copy link
Member

  • flake: add initial flake-parts module
  • flake: add nixvimConfigurations flake-parts module
  • flake: add nixvimModules flake-parts module

This adds flake-parts modules for declaring flake.nixvimModules and perSystem.nixvimConfigurations. A default module imports both of these.

This is currently undocumented. It should be possible to document these modules in a similar way to how we document platform-wrappers. We may also want to document our flake-parts modules on the flake.parts website?

@traxys also proposed having some auto-configuration, which I agree is a good idea. However I'd like to keep the scope of this PR small, so let's postpone that for now.

@MattSturgeon
Copy link
Member Author

Re documentation:

I've sent hercules-ci/flake.parts-website#1288 upstream that should allow us to leverage the flake-parts-website tooling without having to also have extra stuff in our flake's packages outupt.

It would require adding flake-parts-website as a flake input though, or fetching it with a fetcher I guess.

The alternative is to use flake-parts-lib.evalFlakeModule manually, but scrolling through render-module.nix there's a few edge-cases & botstrapping we may need to handle too if we take that approach.

@MattSturgeon MattSturgeon force-pushed the flake-parts-module branch 3 times, most recently from 79c069e to 02bd468 Compare January 19, 2025 14:17
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me overall.

@MattSturgeon
Copy link
Member Author

@mergify queue

Copy link
Contributor

mergify bot commented Jan 19, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8fb2fe2

Copy link
Contributor

mergify bot commented Jan 19, 2025

This pull request, with head sha 8fb2fe22c237b25b8af346870e126fdaeaff688b, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha 8fb2fe22c237b25b8af346870e126fdaeaff688b is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch flake-parts-module, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit 8fb2fe2 into nix-community:main Jan 19, 2025
4 checks passed
@mergify mergify bot temporarily deployed to github-pages January 19, 2025 18:17 Inactive
@MattSturgeon MattSturgeon deleted the flake-parts-module branch January 19, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants