-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/options: lib/neovim-plugin: Add lazyLoad option to plugins #1866
Conversation
This function will be used to generate lazyLoad options for plugins. It is defined in options for later use in mkNeovimPlugin.
Uses options defined by mkLazyLoadOption.
Using mkLazyLoadOption generate lazyLoad option for all plugins generated using mkNeovimPlugin. Plugin maintainers can opt out by setting `allowLazyLoad = false`. Plugin maintainers can provide default vaules by setting option in lazyLoad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, I'm sure many people will be pleased to see progress here!
I haven't taken a proper look yet, but I left some comments below.
- Would it be possible to extract parts of this into smaller PRs?
- E.g. initializing
plugins.lz-n
could be its own PR.
- E.g. initializing
- Would it be possible for
mkLazyLoadOption
to work with eitherplugins.lz-n
orplugins.lazy
based on user preference?
Thank you for your review!
Yes, I am going to make a PR for lz-n, and use that PR as base for the lazyLoad options
Yes, I think it should be possible. I could add a |
This PR works on a solution for the issue #421.
Already implemented
mkLazyLoadOption
to generate lazyLoad options for plugins.mkNeovimPlugin
Planned
extraConfigLua
from extraConfig.mkVimPlugin