Skip to content

Commit

Permalink
plugins/nonels/prettierd: add disableTsServerFormatting option to pre…
Browse files Browse the repository at this point in the history
…ttierd

Add a new option (and warning) to disable the typescript-language-server (ts_ls) formatting the same as for prettier.
  • Loading branch information
Pyxels authored and nix-infra-bot committed Nov 13, 2024
1 parent 7dc65b2 commit d593b82
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 1 deletion.
45 changes: 45 additions & 0 deletions plugins/by-name/none-ls/prettierd.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
{
lib,
config,
options,
...
}:
let
cfg = config.plugins.none-ls.sources.formatting.prettierd;
ts-ls-cfg = config.plugins.lsp.servers.ts_ls;
opt = options.plugins.none-ls.sources.formatting.prettierd;
defaultPrio = (lib.mkOptionDefault null).priority;
in
{
options.plugins.none-ls.sources.formatting.prettierd = {
disableTsServerFormatter = lib.mkOption {
type = lib.types.bool;
description = ''
Disables the formatting capability of the `ts_ls` language server if it is enabled.
'';
default = false;
example = true;
};
};

config = lib.mkIf cfg.enable {
warnings =
lib.optional (opt.disableTsServerFormatter.highestPrio == defaultPrio && ts-ls-cfg.enable)
''
You have enabled the `prettierd` formatter in none-ls.
You have also enabled the `ts_ls` language server which also brings a formatting feature.
- To disable the formatter built-in the `ts_ls` language server, set
`plugins.none-ls.sources.formatting.prettierd.disableTsServerFormatter` to `true`.
- Else, to silence this warning, explicitly set the option to `false`.
'';

plugins.lsp.servers.ts_ls =
lib.mkIf (cfg.enable && ts-ls-cfg.enable && cfg.disableTsServerFormatter)
{
onAttach.function = ''
client.server_capabilities.documentFormattingProvider = false
'';
};
};
}
5 changes: 4 additions & 1 deletion plugins/by-name/none-ls/sources.nix
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ let
in
{
imports =
[ ./prettier.nix ]
[
./prettier.nix
./prettierd.nix
]
++ (lib.flatten (
lib.mapAttrsToList (category: (lib.map (mkSourcePlugin category))) noneLsBuiltins
));
Expand Down

0 comments on commit d593b82

Please sign in to comment.