-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssh: made the ssh config file path modular #3852
base: master
Are you sure you want to change the base?
Conversation
made a new option programs.ssh.userConfigFile with default ".ssh/config" and replaced home.file.".ssh/config".text with home.file.${cfg.userConfigFile}.text
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
Shouldn't the generation of the alias be another option included with this? |
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
Okay, I think that can be put aside for another pr. Having this here merged would be huge |
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
Still important |
rather than adding yet another config item, you could disable the writing of the file (e.g. |
Co-authored-by: Austin Horstman <[email protected]>
Co-authored-by: Austin Horstman <[email protected]>
Co-authored-by: Austin Horstman <[email protected]>
the wording @khaneliman suggested is more intuitive, let's go with that instead ^^ |
made a new option programs.ssh.userConfigFile with default ".ssh/config" and replaced home.file.".ssh/config".text with home.file.${cfg.userConfigFile}.text
Description
adds an Option programs.ssh.userConfigFile which expects a String returned (default .ssh/config).
replaces home.file.".ssh/config".txt with home.file.${cfg.userConfigFile}.txt
can be used together with an Alias (ssh = ssh -F /path/to/file) to declutter the home directory
default option for userConfigFile is still ".ssh/config"
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
this PR doesn't add a new Module.