-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move repo to nixpkgs-24.05 #523
Conversation
I finally found, why @aldoborrero @selfuryon Could you give some feedback? Thanks! |
@catwith1hat apologies as these past few weeks I've been mostly out in terms of |
No rush. I just wanted to make sure that nobody else is working it :). |
Maybe this could be looked at in the next few days? :) Thanks! |
@catwith1hat again apologies with the delay. I executed
Maybe, some of the commits can be cherry-picked and incorporated into separate PRs and we can incorporate them faster whilst we're still solving all of the remaining issues: |
Trying to pull up ssvnode over here: ssvlabs/ssv#1478 |
Please retry. Somehow the updates break the hashes of erigon/geth. |
When we bump nixpkgs to 24.05 some packages need to stay behind, as they don't compile with 24.05.
nixpkgs-24.05, even when system = "x86_64-linux" will instantiate a nixpkgs configuration for i686-linux. I believe that this is because of the stdenv bootstrapping in <nixpkgs/pkgs/stdenv/linux/default.nix> references an i686-linux version of glibc. Because modules/testing.nix references the overlay definition, and because of the bootstrapping logic above, we need to make the flake overlay definition to handle unknown systems more gracefully. Return an empty set, in case we don't know the system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@catwith1hat thanks for taking the lead. LGTM.
Here is a set of commits that moves the repo to nixpkgs-24.05.
Feedback welcome.