Add tests for Lighthouse Validator #400
Open
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why mev-boost failed the build... I can't see anything in the logs available to me and it builds just fine locally. |
|
@scottbot95 see the comment I've written and let's decide on a better approach rather than starting and stopping twice the service (which I'm totally fine if we introduce more checks in the middle). |
scottbot95
force-pushed
the
lighthouse-service
branch
from
13740a9 to
b89f83b
Compare
scottbot95
force-pushed
the
lighthouse-service
branch
from
b89f83b to
83f33b8
Compare
|
@aldoborrero I updated the test for lighthouse validator tests per your suggestions. It's probably worth creating an issue to follow-up and update other tests/fill-in missing tests with this pattern. I wonder if it's also worth trying to formalize it in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic test for Lighthouse Validator. Pretty much just tests that the service starts up and doesn't crash immediately (see my comment on my last PR)