-
-
Notifications
You must be signed in to change notification settings - Fork 26
Split gopkgs #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Split gopkgs #50
Conversation
3ed2747
to
4038843
Compare
Can't we split the stuff into multiple outputs and install only the outputs that are actually needed? If you need any input on how to implement that, let me know. |
41b79bb
to
e101c0e
Compare
So I tried split packages, it makes for a much cleaner code (see last push)! However, while the outpost doesn't contain the server binary, they still refer to some packages that are not actually needed but get included anyways, negating a good chunk of the size benefits. Here's a comparison from old method to new method:
If the solution comes directly to you, let me know, otherwise I'll take some time to dig in the docs. |
Hmm, is it closure size that's increased or the binaries? |
e101c0e
to
e0fc3ba
Compare
@GeoffreyFrogeye is there a reason this is still a draft? |
It's in draft because:
I'm still intending to work on this, but given this I think it's best to wait a bit. |
This reduce the size of the closures for the outposts.
Example for a machine that only uses the
proxy
outpost:I am not so sure this way of doing it is very clean, you need to copy the name of the outposts multiple times since it seems you can make an attr a package. Split packages doesn't sounds appropriate either, because then outpost depdends on the Python stuff even though it wouldn't actually change the binary.
Stuff that I removed because it didn't seem to be needed:
bin/proxy
in the server package. IIUC the server doesn't call the proxy binary, it's just built-in.doCheck = false
I wanted to see for which binaries it was needed, turns out none?Based on #46, so keeping as a draft until it and maybe #48 are merged. Just sounds like less work overall (and I can also test this MR as I require the proxy outpost). Tests are timing out,
even though they aren't in my other MR so maaaybe it's something I didit's also timing out on other MRs.