JSONQGet + JSON.INDEX ADD #40
Open
+250
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 15, 2020 11:25
…JSON and RediSearch, making a GET with Query
Pull Request Test Coverage Report for Build 97
💛 - Coveralls |
Shivam010
requested changes
Mar 4, 2020
Comment on lines
17
to
+27
| type ReJSON interface { | ||
| JSONSet(key, path string, obj interface{}, opts ...rjs.SetOption) (res interface{}, err error) | ||
|
|
||
| JSONSetWithIndex(key, path string, obj interface{}, index string) (res interface{}, err error) | ||
|
|
||
| JSONGet(key, path string, opts ...rjs.GetOption) (res interface{}, err error) | ||
|
|
||
| JSONQGet(key string, params ...string) (res interface{}, err error) | ||
|
|
||
| JSONIndexAdd(key, field, path string) (res interface{}, err error) | ||
|
|
There was a problem hiding this comment.
Instead of adding these methods in ReJSON interface create a separate interface ReJSON2 and embed ReJSON interfaces in it along with the new methods. And create a separate handler for the ReJSON2, so that the new module won't affect the original one.
Something like this:
Suggested change
| type ReJSON interface { | |
| JSONSet(key, path string, obj interface{}, opts ...rjs.SetOption) (res interface{}, err error) | |
| JSONSetWithIndex(key, path string, obj interface{}, index string) (res interface{}, err error) | |
| JSONGet(key, path string, opts ...rjs.GetOption) (res interface{}, err error) | |
| JSONQGet(key string, params ...string) (res interface{}, err error) | |
| JSONIndexAdd(key, field, path string) (res interface{}, err error) | |
| type ReJSON2 interface { | |
| ReJSON | |
| JSONSetWithIndex(key, path string, obj interface{}, index string) (res interface{}, err error) | |
| JSONQGet(key string, params ...string) (res interface{}, err error) | |
| JSONIndexAdd(key, field, path string) (res interface{}, err error) | |
| } |
Comment on lines
+85
to
+93
| func (r *Handler) JSONSetWithIndex(key string, path string, obj interface{}, index string) ( | ||
| res interface{}, err error) { | ||
|
|
||
| if r.clientName == rjs.ClientInactive { | ||
| return nil, rjs.ErrNoClientSet | ||
| } | ||
| return r.implementation.JSONSetWithIndex(key, path, obj, index) | ||
| } | ||
|
|
There was a problem hiding this comment.
Create a separate handler for the ReJSON2, and implement the ReJSON2 interface on it.
You can also wrap the original handler and create a new handler for ReJSON2.
Comment on lines
+117
to
+134
| func (r *Handler) JSONQGet(key string, params ...string) (res interface{}, err error) { | ||
| if r.clientName == rjs.ClientInactive { | ||
| return nil, rjs.ErrNoClientSet | ||
| } | ||
| return r.implementation.JSONQGet(key, params...) | ||
| } | ||
|
|
||
| // JSONAddIndex used to get a json object | ||
| // | ||
| // ReJSON syntax: | ||
| // JSON.INDEX ADD <index> <field> <path> | ||
| // | ||
| func (r *Handler) JSONIndexAdd(index, field, path string) (res interface{}, err error) { | ||
| if r.clientName == rjs.ClientInactive { | ||
| return nil, rjs.ErrNoClientSet | ||
| } | ||
| return r.implementation.JSONIndexAdd(index, field, path) | ||
| } |
There was a problem hiding this comment.
Same for all new methods
Comment on lines
+53
to
+55
| ReJSONCommandQGET ReJSONCommandID = 20 | ||
| ReJSONCommandINDEXADD ReJSONCommandID = 21 | ||
| ReJSONCommandSETINDEX ReJSONCommandID = 22 |
There was a problem hiding this comment.
Just a suggestion to differentiate from others
Suggested change
| ReJSONCommandQGET ReJSONCommandID = 20 | |
| ReJSONCommandINDEXADD ReJSONCommandID = 21 | |
| ReJSONCommandSETINDEX ReJSONCommandID = 22 | |
| ReJSON2CommandQGET ReJSONCommandID = 20 | |
| ReJSON2CommandINDEXADD ReJSONCommandID = 21 | |
| ReJSON2CommandSETINDEX ReJSONCommandID = 22 |
Shivam010
requested changes
Mar 4, 2020
|
Hey @breno12321 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created functions to use the RedisJSON2 JSON.QGet, JSON.INDEX add and a JSON.SETWithIndex