Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NUnit Version to 4.3.2 #1517

Merged
merged 5 commits into from
Mar 21, 2025
Merged

Update NUnit Version to 4.3.2 #1517

merged 5 commits into from
Mar 21, 2025

Conversation

tonyqus
Copy link
Member

@tonyqus tonyqus commented Mar 21, 2025 •
edited
Loading

Fix test case failures
Update NUnit and NUnitAdapter to latest version

@lahma
Copy link
Collaborator

lahma commented Mar 21, 2025

You could make the change less dramatic by using global using alias, no need to use ClassicAssert then everywhere:

https://docs.nunit.org/articles/nunit/release-notes/Nunit4.0-MigrationGuide.html#use-global-using-aliases

@tonyqus
Copy link
Member Author

tonyqus commented Mar 21, 2025 •
edited
Loading

I really don't like what NUnit changed. Too many breaking changes

@tonyqus tonyqus added this to the NPOI 2.7.3 milestone Mar 21, 2025
@tonyqus tonyqus added the cicd label Mar 21, 2025
@tonyqus tonyqus merged commit 622f54c into nissl-lab:master Mar 21, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cicd
Projects
None yet
Milestone
NPOI 2.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyqus @lahma