Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clone sheet when the sheet contains hyperlinks #1441

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Fix Clone sheet when the sheet contains hyperlinks #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ooxml/XSSF/UserModel/XSSFWorkbook.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ public ISheet CloneSheet(int sheetNum, String newName)
if (pr.TargetMode == TargetMode.External)
{
clonedSheet.GetPackagePart().AddExternalRelationship
(pr.TargetUri.OriginalString, pr.RelationshipType, null);
(pr.TargetUri.OriginalString, pr.RelationshipType, pr.Id);
}
}
}
Expand Down
18 changes: 18 additions & 0 deletions testcases/ooxml/XSSF/UserModel/TestCloneSheet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
using NUnit.Framework;
using System.IO;

namespace NPOI.XSSF.UserModel
{
[TestFixture]
public class TestCloneSheet
{
[Test]
public void TestCloneHyperlink()
{
using(var workbook = XSSFTestDataSamples.OpenSampleWorkbook("1370_clonesheet_withhyperlink.xlsx"))
{
workbook.CloneSheet(0,"Sheet2");
}
}
}
}
Binary file added testcases/test-data/spreadsheet/1370_clonesheet_withhyperlink.xlsx
View file
Open in desktop
Binary file not shown.
Loading