Skip to content

Commit

Permalink
[Fix] Github Action for Firebase hosting in PR (#201)
Browse files Browse the repository at this point in the history
* Remove if condition before running the build and preview job in Firebase Github Action for PR

* Add a name to job for merge
  • Loading branch information
nisrulz committed Jun 3, 2024
1 parent 41ee882 commit b88c9ab
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/firebase-hosting-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ name: Deploy to Production
- master
jobs:
build_and_deploy:
name: Build and Deploy
runs-on: ubuntu-latest
steps:
- name: Checkout the code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase-hosting-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ name: Deploy to Firebase Hosting on PR
'on': pull_request
jobs:
build_and_preview:
if: '${{ github.event.pull_request.head.repo.full_name == github.repository }}'
name: Build and Preview
runs-on: ubuntu-latest
steps:
- name: Checkout the code
Expand Down

0 comments on commit b88c9ab

Please sign in to comment.