Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data quirks #36

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Data quirks #36

wants to merge 3 commits into from

Conversation

mz8i
Copy link
Contributor

@mz8i mz8i commented Nov 23, 2023

Depends on #35 being merged first.

Removal of data quirk handling introduced before the release of global tool version.

Handles points 1, 2 and 3 from nismod/infra-risk-vis#161

Feature property names containing hazard, rcp, epoch - are assumed to
contain standardised values.
Epoch baseline values are expected to always be 'baseline'
@mz8i
Copy link
Contributor Author

mz8i commented Nov 23, 2023

tests to check that the backend data has been correctly updated:

in feature property names (damages):

  • "historical" substring doesn't appear in property names - only "baseline"
  • "rcp_rcp", "rcp_historical" substring doesn't appear in property names - in infrastructure datasets
  • "epoch_2020", "epoch_1980", "epoch_present" don't appear in property names

Consider fixing the quirks also in adm0_exposure - to find this and other leftovers, search for "TODO: quirks"

@mz8i mz8i changed the base branch from main to general-refactor December 19, 2023 18:44
@mz8i mz8i changed the base branch from general-refactor to main December 19, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant