Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Save CIFTI subcortical volumes #357

Closed
wants to merge 1 commit into from

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Apr 4, 2024

Address #251

  • My preference remains only outputting the CIFTI, and allowing users to derive this with wb_command -cifti-separate <input-cifti> COLUMN -volume-all <output-file>
  • This will increase output size, as another copy of the BOLD series will now be present.
    • Perhaps we want to output a mask + xfm that can be applied instead (and fits better with the fit/apply approach we are moving towards)

Note: The ROI is not guaranteed to be in LAS orientation, as the reorienting happens directly in the dtseries creation workflow

Some notes:
- My preference remains outputing the CIFTI, and allowing users to get this file with `wb_command -cifti-separate`
- This will increase output size, as another copy of the BOLD series will now be present.
- Perhaps we want to output a mask + xfm that can be applied instead (fit/apply)
- The ROI is not guaranteed to be in LAS orientation, as the reorienting happens directly in the dtseries creation workflow
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.13%. Comparing base (7b1e91d) to head (59981d9).
Report is 243 commits behind head on master.

Files with missing lines Patch % Lines
nibabies/workflows/bold/outputs.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   33.14%   33.13%   -0.01%     
==========================================
  Files          55       55              
  Lines        5340     5341       +1     
==========================================
  Hits         1770     1770              
- Misses       3570     3571       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd
Copy link
Collaborator Author

mgxd commented Aug 1, 2024

This should implement a single label volume in MNI152 space.

@mgxd mgxd closed this Aug 1, 2024
@mgxd mgxd deleted the enh/ds-cifti-subcortical branch August 1, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant