Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subject collection (again) #78

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix subject collection (again) #78

merged 1 commit into from
Sep 23, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Sep 23, 2024

Stems from #77. The fix in #77 doesn't work when config.execution.bids_filters is None.

@tsalo tsalo added the bug Something isn't working label Sep 23, 2024
@tsalo tsalo merged commit 26820ba into main Sep 23, 2024
9 of 10 checks passed
@tsalo tsalo deleted the fix-subject-collection-2 branch September 23, 2024 16:19
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.59%. Comparing base (062a726) to head (b80a99e).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/workflows/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   30.59%   30.59%           
=======================================
  Files          26       26           
  Lines        2363     2363           
  Branches      374      374           
=======================================
  Hits          723      723           
  Misses       1617     1617           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant