Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bids-validator installation and usage #76

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Fix bids-validator installation and usage #76

merged 5 commits into from
Sep 23, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Sep 23, 2024

Closes #74.

Changes proposed in this pull request

  • Install bids-validator v1.14.10 instead of newer version.
  • Only validate dataset if running in raw+derivative mode.
  • Print out the collected runs.

@tsalo tsalo added the bug Something isn't working label Sep 23, 2024
@tsalo tsalo merged commit df73880 into main Sep 23, 2024
10 checks passed
@tsalo tsalo deleted the fix-validator branch September 23, 2024 15:34
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.62%. Comparing base (2f1aade) to head (35b35ae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/cli/parser.py 0.00% 2 Missing ⚠️
src/fmripost_aroma/workflows/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   30.64%   30.62%   -0.03%     
==========================================
  Files          26       26              
  Lines        2359     2361       +2     
  Branches      374      374              
==========================================
  Hits          723      723              
- Misses       1613     1615       +2     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIDS validator not installed correctly?
1 participant