Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write out GeneratedBy correctly #73

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Write out GeneratedBy correctly #73

merged 3 commits into from
Sep 23, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Sep 21, 2024

Closes #70.

Changes proposed in this pull request

@tsalo tsalo added the bug Something isn't working label Sep 21, 2024
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 2.56410% with 38 lines in your changes missing coverage. Please review.

Project coverage is 30.58%. Comparing base (24a0dcf) to head (1e99d15).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/utils/bids.py 2.63% 37 Missing ⚠️
src/fmripost_aroma/cli/run.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   30.85%   30.58%   -0.28%     
==========================================
  Files          26       26              
  Lines        2330     2351      +21     
  Branches      365      370       +5     
==========================================
  Hits          719      719              
- Misses       1590     1611      +21     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit fbf0540 into main Sep 23, 2024
10 of 12 checks passed
@tsalo tsalo deleted the generatedby branch September 23, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeneratedBy field isn't inherited/modified correctly
1 participant