Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confound generation #67

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Fix confound generation #67

merged 3 commits into from
Sep 20, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Sep 20, 2024

Closes none.

Changes proposed in this pull request

  • Confounds (desc-aroma_timeseries.tsv) were being selected by time instead of by component.
  • Orthogonalization of confounds was done on zero-padded time series.
  • Mixing matrix was written out to derivatives without zero padding.

@tsalo tsalo added the bug Something isn't working label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 30.87%. Comparing base (92bd92b) to head (4dddf70).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/interfaces/confounds.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   30.93%   30.87%   -0.07%     
==========================================
  Files          26       26              
  Lines        2324     2329       +5     
  Branches      363      365       +2     
==========================================
  Hits          719      719              
- Misses       1584     1589       +5     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit 66b4c66 into main Sep 20, 2024
10 of 12 checks passed
@tsalo tsalo deleted the fix-orthogonalization branch September 20, 2024 14:43
@tsalo tsalo mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant