Export types used in the exported cow_http2:frame() type #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exclusive and weight are not necessary because PRIORITY will not be implemented. Cowlib 3.0 will probably not return that information. Settings could be good but in that case the type should be more detailed than |
bjosv
pushed a commit
to Nordix/cowlib
that referenced
this pull request
May 14, 2024
… type With these types exported, a frame() can be decomposed and all parts can be typed using exported types. Signed-off-by: Viktor Söderqvist <[email protected]> Merged PR: ninenines#137
… type With these types exported, a frame() can be decomposed and all parts can be typed using exported types. Signed-off-by: Viktor Söderqvist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these types exported, a frame() can be decomposed and all parts can be typed using exported types.