Add permessage-deflate approx max option #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an `approx_max` option to control memory usage. This is approx because `zlib:safeInflate` chunk sizes are not configurable so the size won't match up exactly, and we also don't check the final chunk (again because of the unconfigurable chunk size). This option is about general memory usage safety rather than enforcing specific application logic limits.
|
Tests are in Cowboy's ws_SUITE. |
|
@essen so should i clone cowboy and update the makefile to point to my branch? i've never really worked with erlang directly before 😅 |
|
You can clone Cowboy, do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
approx_maxoption to control memory usage. This is approxbecause
zlib:safeInflatechunk sizes are not configurable so thesize won't match up exactly, and we also don't check the final chunk
(again because of the unconfigurable chunk size). This option is
about general memory usage safety rather than enforcing specific
application logic limits.
I'm not sure if I'm missing something but there don't appear to be any tests in this repo... How should one go about testing and verifying a change works?