Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect a return value of Transport:send/2 #1590

Closed
wants to merge 2 commits into from
Closed

Respect a return value of Transport:send/2 #1590

wants to merge 2 commits into from

Conversation

Yozhig
Copy link
Contributor

@Yozhig Yozhig commented Nov 22, 2022 •
edited
Loading

fixes #1589

@Yozhig Yozhig mentioned this pull request Nov 22, 2022
Closed
@essen essen added this to the 2.11 milestone Nov 23, 2023
@essen
Copy link
Member

essen commented Dec 5, 2023

Please rebase onto current master so that CI runs properly. I am planning to do a release with this and other things soon.

@essen
Copy link
Member

essen commented Dec 12, 2023

Hello! I have done a more complete patch covering all the Transport related errors as well as adding a test for HTTP/2 and fixing HTTP/2 as well. I have kept the test commit and added the HTTP/2 test there, then added another commit with the fixes. This also involved adding some information to the documentation because this impacts how stream handler commands are handled (they can now be interrupted by socket errors). Closing, thanks!

@essen essen closed this Dec 12, 2023
@Yozhig
Copy link
Contributor Author

Yozhig commented Dec 13, 2023

I can't test it right now but it looks good to me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

Connections hang in CLOSED state
2 participants
@Yozhig @essen