Option to skip "name this contact" screen when send a TX to an unknown address. #30
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding a TX to a previously unknown address, which is a hassle if one is mostly sending to one-time addresses, e.g. to companies, collaborators, etc. in a professional setup
|
@svub generally absolutely understandable use-case, definitely is quicker without that step. The issue is that the "Name this contact" screen is our confirmation screen for the address, to check the identicon, confirm that this is the right address. We just also use it to get people to label the address, which is not required. If we leave that step away we risk to have confusion towards the next step and people re-checking the address afterwards. Furthermore, I definitely see a use-case in also naming one-time addresses: Having a label in the TX list to whom I sent a certain transaction helps understand my TX history better than just having addresses – even if it's just single-time payments. |
mraveux
force-pushed
the
master
branch
2 times, most recently
from
3f6cb2f
to
54be1c4
Compare
sisou
force-pushed
the
master
branch
2 times, most recently
from
b1c3ad0
to
40c00f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added switch to setting panel that enables to skipping the labeling screen "name this contact" when sending a TX to a previously unknown address. Why? It's a hassle if one is mostly sending to one-time addresses, e.g. to companies, collaborators, etc. in a professional setup - so such a custom setting comes handy.